chrome/browser/geolocation/geolocation_permission_context_unittest.cc - Issue 1158813002: Use RenderFrameHost for ::RequestPermission() and ::CancelPermission().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

Issue 1158813002: Use RenderFrameHost for ::RequestPermission() and ::CancelPermission(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: build fixes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/geolocation_permission_context.cc ('k') | chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

diff --git a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

index 677508735cb18e6ca3ddf63b519467aa20f0a3f3..70d13d5d536c6a9579328a5734dde1c7c883fe85 100644

--- a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

+++ b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

@@ -36,6 +36,7 @@

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

#include "content/public/browser/notification_service.h"

+#include "content/public/browser/render_frame_host.h"

#include "content/public/browser/web_contents.h"

#include "content/public/test/mock_render_process_host.h"

#include "content/public/test/test_renderer_host.h"

@@ -162,7 +163,7 @@ PermissionRequestID GeolocationPermissionContextTests::RequestID(

int bridge_id) {

return PermissionRequestID(

web_contents()->GetRenderProcessHost()->GetID(),

- web_contents()->GetRenderViewHost()->GetRoutingID(),

+ web_contents()->GetMainFrame()->GetRoutingID(),

bridge_id,

GURL());

}

@@ -172,7 +173,7 @@ PermissionRequestID GeolocationPermissionContextTests::RequestIDForTab(

int bridge_id) {

return PermissionRequestID(

extra_tabs_[tab]->GetRenderProcessHost()->GetID(),

- extra_tabs_[tab]->GetRenderViewHost()->GetRoutingID(),

+ extra_tabs_[tab]->GetMainFrame()->GetRoutingID(),

bridge_id,

GURL());

}