Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6866)

Unified Diff: chrome/browser/content_settings/tab_specific_content_settings.cc

Issue 1158813002: Use RenderFrameHost for ::RequestPermission() and ::CancelPermission(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build fixes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/tab_specific_content_settings.cc
diff --git a/chrome/browser/content_settings/tab_specific_content_settings.cc b/chrome/browser/content_settings/tab_specific_content_settings.cc
index 89d968c54e6e377c29f3ba17f05f606c84f2328b..e81ca2aa8b2d9f817ae59aa18003bef3c64580b3 100644
--- a/chrome/browser/content_settings/tab_specific_content_settings.cc
+++ b/chrome/browser/content_settings/tab_specific_content_settings.cc
@@ -49,27 +49,12 @@
using content::BrowserThread;
using content::NavigationController;
using content::NavigationEntry;
-using content::RenderViewHost;
using content::WebContents;
DEFINE_WEB_CONTENTS_USER_DATA_KEY(TabSpecificContentSettings);
namespace {
-// Returns the object given a render frame's id.
-TabSpecificContentSettings* GetForFrame(int render_process_id,
- int render_frame_id) {
- DCHECK_CURRENTLY_ON(BrowserThread::UI);
-
- content::RenderFrameHost* frame = content::RenderFrameHost::FromID(
- render_process_id, render_frame_id);
- WebContents* web_contents = WebContents::FromRenderFrameHost(frame);
- if (!web_contents)
- return nullptr;
-
- return TabSpecificContentSettings::FromWebContents(web_contents);
-}
-
ContentSettingsUsagesState::CommittedDetails GetCommittedDetails(
const content::LoadCommittedDetails& details) {
ContentSettingsUsagesState::CommittedDetails committed_details;
@@ -133,19 +118,16 @@ TabSpecificContentSettings::~TabSpecificContentSettings() {
SiteDataObserver, observer_list_, ContentSettingsDestroyed());
}
-// static
-TabSpecificContentSettings* TabSpecificContentSettings::Get(
- int render_process_id, int render_view_id) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-
- RenderViewHost* view = RenderViewHost::FromID(render_process_id,
- render_view_id);
- if (!view)
- return NULL;
+TabSpecificContentSettings* TabSpecificContentSettings::GetForFrame(
+ int render_process_id,
+ int render_frame_id) {
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
- WebContents* web_contents = WebContents::FromRenderViewHost(view);
+ content::RenderFrameHost* frame = content::RenderFrameHost::FromID(
+ render_process_id, render_frame_id);
+ WebContents* web_contents = WebContents::FromRenderFrameHost(frame);
if (!web_contents)
- return NULL;
+ return nullptr;
return TabSpecificContentSettings::FromWebContents(web_contents);
}

Powered by Google App Engine
This is Rietveld 408576698