components/content_settings/core/common/permission_request_id.h - Issue 1158813002: Use RenderFrameHost for ::RequestPermission() and ::CancelPermission().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/common/permission_request_id.h

Issue 1158813002: Use RenderFrameHost for ::RequestPermission() and ::CancelPermission(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/geolocation/geolocation_permission_context.cc ('K') | « chromecast/browser/cast_permission_manager.cc ('k') | components/content_settings/core/common/permission_request_id.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/common/permission_request_id.h

diff --git a/components/content_settings/core/common/permission_request_id.h b/components/content_settings/core/common/permission_request_id.h

index a9252a15c72d81ff7ae3d3864262b22ddc6e1018..9ee89c44c23c2ccc1449865cb8ce132b39462cae 100644

--- a/components/content_settings/core/common/permission_request_id.h

+++ b/components/content_settings/core/common/permission_request_id.h

@@ -13,13 +13,13 @@

class PermissionRequestID {

public:

PermissionRequestID(int render_process_id,

- int render_view_id,

+ int render_frame_id,

int bridge_id,

const GURL& origin);

~PermissionRequestID();

int render_process_id() const { return render_process_id_; }

- int render_view_id() const { return render_view_id_; }

+ int render_frame_id() const { return render_frame_id_; }

int bridge_id() const { return bridge_id_; }

GURL origin() const { return origin_; }

@@ -29,7 +29,7 @@ class PermissionRequestID {

private:

int render_process_id_;

- int render_view_id_;

+ int render_frame_id_;

// Id unique to this instance.

int bridge_id_;

// Needed for permission checks that are based on origin.