Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1864)

Unified Diff: android_webview/browser/aw_permission_manager.cc

Issue 1158813002: Use RenderFrameHost for ::RequestPermission() and ::CancelPermission(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_permission_manager.cc
diff --git a/android_webview/browser/aw_permission_manager.cc b/android_webview/browser/aw_permission_manager.cc
index eb517b41083261ea53a6da54a7ab538f53b5a333..8daea9716006386055a16ffbfb6e8d6820bf831d 100644
--- a/android_webview/browser/aw_permission_manager.cc
+++ b/android_webview/browser/aw_permission_manager.cc
@@ -7,9 +7,8 @@
#include "android_webview/browser/aw_browser_permission_request_delegate.h"
#include "base/callback.h"
#include "content/public/browser/permission_type.h"
+#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
-#include "content/public/browser/render_view_host.h"
-#include "content/public/browser/web_contents.h"
namespace android_webview {
@@ -33,16 +32,16 @@ AwPermissionManager::~AwPermissionManager() {
void AwPermissionManager::RequestPermission(
content::PermissionType permission,
- content::WebContents* web_contents,
+ content::RenderFrameHost* render_frame_host,
int request_id,
const GURL& origin,
bool user_gesture,
const base::Callback<void(content::PermissionStatus)>& callback) {
- int render_process_id = web_contents->GetRenderProcessHost()->GetID();
- int render_view_id = web_contents->GetRenderViewHost()->GetRoutingID();
+ int render_process_id = render_frame_host->GetProcess()->GetID();
+ int render_frame_id = render_frame_host->GetRoutingID();
AwBrowserPermissionRequestDelegate* delegate =
AwBrowserPermissionRequestDelegate::FromID(render_process_id,
- render_view_id);
+ render_frame_host);
if (!delegate) {
DVLOG(0) << "Dropping permission request for "
<< static_cast<int>(permission);
@@ -75,14 +74,14 @@ void AwPermissionManager::RequestPermission(
void AwPermissionManager::CancelPermissionRequest(
content::PermissionType permission,
- content::WebContents* web_contents,
+ content::RenderFrameHost* render_frame_host,
int request_id,
const GURL& origin) {
- int render_process_id = web_contents->GetRenderProcessHost()->GetID();
- int render_view_id = web_contents->GetRenderViewHost()->GetRoutingID();
+ int render_process_id = render_frame_host->GetProcess()->GetID();
+ int render_frame_id = render_frame_host->GetRoutingID();
AwBrowserPermissionRequestDelegate* delegate =
AwBrowserPermissionRequestDelegate::FromID(render_process_id,
- render_view_id);
+ render_frame_id);
if (!delegate)
return;

Powered by Google App Engine
This is Rietveld 408576698