Issue 11588008: Compile fix for r173417.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11588008: Compile fix for r173417. (Closed)

Created:
8 years ago by mtomasz

Modified:
8 years ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Compile fix for r173417. BUG=156772 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173418

Patch Set 2 : Fixed code style. #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ash/launcher/launcher.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

LGTM, mod nit https://codereview.chromium.org/11588008/diff/1/ash/launcher/launcher.h File ash/launcher/launcher.h (right): https://codereview.chromium.org/11588008/diff/1/ash/launcher/launcher.h#newcode134 ash/launcher/launcher.h:134: views::Widget* widget, bool active) OVERRIDE; nit: ...

8 years ago (2012-12-17 04:57:56 UTC) #1

mtomasz

8 years ago (2012-12-17 05:01:56 UTC) #2

https://codereview.chromium.org/11588008/diff/1/ash/launcher/launcher.h
File ash/launcher/launcher.h (right):

https://codereview.chromium.org/11588008/diff/1/ash/launcher/launcher.h#newco...
ash/launcher/launcher.h:134: views::Widget* widget, bool active) OVERRIDE;
On 2012/12/17 04:57:56, Ryan Sleevi wrote:
> nit: extra linebreak here
> 
> virtual void OnWidgetActivationChanged(views::Widget* widget,
>                                        bool active) OVERRIDE;

Done.

Expand Messages | Collapse Messages

Issue 11588008: Compile fix for r173417. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fixed code style. #

Messages