chrome/common/extensions/extension_file_util.cc - Issue 11588004: Move ScriptBadge, ActionInfo out of Extension; preparation for BrowserAction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_file_util.cc

Issue 11588004: Move ScriptBadge, ActionInfo out of Extension; preparation for BrowserAction (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/extension.cc ('K') | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | chrome/common/extensions/manifest_tests/extension_manifests_scriptbadge_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_file_util.cc

diff --git a/chrome/common/extensions/extension_file_util.cc b/chrome/common/extensions/extension_file_util.cc

index d6dea3fc44a7c4342c0c007e28626e1c2f7efb0a..0a14fef566cbe63e3ba5ba26cf9a49908d38dae6 100644

--- a/chrome/common/extensions/extension_file_util.cc

+++ b/chrome/common/extensions/extension_file_util.cc

@@ -19,6 +19,7 @@

#include "base/utf_string_conversions.h"

#include "chrome/common/chrome_constants.h"

#include "chrome/common/chrome_paths.h"

+#include "chrome/common/extensions/api/extension_action/action_info.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_l10n_util.h"

#include "chrome/common/extensions/extension_manifest_constants.h"

@@ -327,7 +328,7 @@ bool ValidateExtension(const Extension* extension,

}

- const Extension::ActionInfo* action = extension->page_action_info();

+ const extensions::ActionInfo* action = extension->page_action_info();

Yoyo Zhou 2012/12/18 02:01:41 Note that it's also not good for this class to kno

if (action && !action->default_icon.empty() &&

!ValidateExtensionIconSet(action->default_icon, extension,

IDS_EXTENSION_LOAD_ICON_FOR_PAGE_ACTION_FAILED, error)) {