Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 1158783011: Web Animations: Don't fire finish event when cancelling (Closed)

Created:
4 years, 11 months ago by dstockwell
Modified:
4 years, 10 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Web Animations: Don't fire finish event when cancelling BUG=496527 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -127 lines) Patch
M LayoutTests/FlakyTests View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
A LayoutTests/web-animations-api/player-cancel-events.html View 1 chunk +30 lines, -0 lines 0 comments Download
D LayoutTests/web-animations-api/player-cancel-finishes.html View 1 chunk +0 lines, -107 lines 0 comments Download
D LayoutTests/web-animations-api/player-cancel-finishes-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/animation/Animation.cpp View 1 chunk +11 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dstockwell
4 years, 11 months ago (2015-06-04 04:55:58 UTC) #2
dstockwell
4 years, 11 months ago (2015-06-05 01:01:57 UTC) #3
dstockwell
4 years, 10 months ago (2015-06-09 00:35:33 UTC) #4
alancutter (OOO until 2018)
lgtm
4 years, 10 months ago (2015-06-09 01:32:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158783011/1
4 years, 10 months ago (2015-06-09 01:36:16 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 03:00:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196725

Powered by Google App Engine
This is Rietveld 408576698