Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: build/toolchain/win/BUILD.gn

Issue 1158763006: clang/win: Start work on getting clang/win working in gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/win/BUILD.gn
diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn
index 05406c39d42cec7a49e7b60263bb55a1a1a8d851..4936c3d0cfc883641333be7dca2617b5fa3eadab 100644
--- a/build/toolchain/win/BUILD.gn
+++ b/build/toolchain/win/BUILD.gn
@@ -39,6 +39,12 @@ if (vc_bin_dir == "") {
vc_bin_dir = toolchain_data.vc_bin_dir
}
+if (use_goma) {
+ goma_prefix = "$goma_dir/gomacc.exe "
+} else {
+ goma_prefix = ""
+}
+
# This value will be inherited in the toolchain below.
concurrent_links = exec_script("../get_concurrent_links.py", [], "value")
@@ -65,13 +71,7 @@ template("msvc_toolchain") {
invoker.current_cpu,
])
- if (use_goma) {
- goma_prefix = "$goma_dir/gomacc.exe "
- } else {
- goma_prefix = ""
- }
-
- cl = "${goma_prefix}\"${vc_bin_dir}/cl.exe\""
+ cl = invoker.cl
toolchain(target_name) {
# Make these apply to all tools below.
@@ -201,6 +201,9 @@ template("msvc_toolchain") {
# passed to the build. They are ignored when this is the default toolchain.
toolchain_args() {
current_cpu = invoker.current_cpu
+ if (defined(invoker.is_clang)) {
+ is_clang = invoker.is_clang
+ }
}
}
}
@@ -210,17 +213,35 @@ template("msvc_toolchain") {
# Right now only one of these can be enabled at a time because the
# runtime libraries get copied to root_build_dir and would collide.
if (current_cpu == "x86") {
- msvc_toolchain("32") {
+ msvc_toolchain("x86") {
environment = "environment.x86"
-
current_cpu = "x86"
+ cl = "${goma_prefix}\"${vc_bin_dir}/cl.exe\""
+ is_clang = false
+ }
+ msvc_toolchain("clang_x86") {
+ environment = "environment.x86"
+ current_cpu = "x86"
+ prefix = rebase_path("//third_party/llvm-build/Release+Asserts/bin",
+ root_build_dir)
+ cl = "${goma_prefix}$prefix/clang-cl.exe"
+ is_clang = true
}
}
if (current_cpu == "x64") {
- msvc_toolchain("64") {
+ msvc_toolchain("x64") {
+ environment = "environment.x64"
+ current_cpu = "x64"
+ cl = "${goma_prefix}\"${vc_bin_dir}/cl.exe\""
+ is_clang = false
+ }
+ msvc_toolchain("clang_x64") {
environment = "environment.x64"
-
current_cpu = "x64"
+ prefix = rebase_path("//third_party/llvm-build/Release+Asserts/bin",
+ root_build_dir)
+ cl = "${goma_prefix}$prefix/clang-cl.exe"
+ is_clang = true
}
}
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698