Issue 115873002: The sandwich is no longer a lie.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115873002: The sandwich is no longer a lie. (Closed)

Created:
7 years ago by jshumway

Modified:
6 years, 11 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

The sandwich is no longer a lie. The sandwichbar sample extension now works on google.com. Confirmed that the pageAction example, page_action_by_content, also works. BUG=110213 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244045

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/common/extensions/docs/examples/api/infobars/sandwichbar/manifest.json	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jaredshumway94@gmail.com/115873002/1

6 years, 11 months ago (2014-01-07 16:40:12 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242504

6 years, 11 months ago (2014-01-07 19:17:18 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jaredshumway94@gmail.com/115873002/1

6 years, 11 months ago (2014-01-09 22:29:25 UTC) #5

Message was sent while issue was closed.

Change committed as 244045

Expand Messages | Collapse Messages