Issue 1158723005: [turbofan] Turn LoadElimination into an AdvancedReducer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1158723005: [turbofan] Turn LoadElimination into an AdvancedReducer. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger

Modified:
5 years, 6 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Turn LoadElimination into an AdvancedReducer. This in turn allows usage of AdvancedReducer::ReplaceWithValue which has access to the underlying graph reducer. R=titzer@chromium.org Committed: https://crrev.com/5cefb367ceac8251b3d7aca27388a4c5e8c95c76 Cr-Commit-Position: refs/heads/master@{#28817}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -6 lines)			Patch
M	src/compiler/load-elimination.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/compiler/load-elimination.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/compiler/pipeline.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/unittests/compiler/load-elimination-unittest.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158723005/1

5 years, 6 months ago (2015-06-05 16:38:44 UTC) #4

commit-bot: I haz the power

5 years, 6 months ago (2015-06-05 16:41:05 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5cefb367ceac8251b3d7aca27388a4c5e8c95c76
Cr-Commit-Position: refs/heads/master@{#28817}