Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(70)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1158723004: DevTools: Fix the inspector/extensions/extensions-audits.html. (Closed)

Created:
4 years, 11 months ago by pfeldman
Modified:
4 years, 11 months ago
Reviewers:
caseq
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Fix the inspector/extensions/extensions-audits.html. BUG=463050 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196578

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -22 lines) Patch
M LayoutTests/FlakyTests View 1 chunk +0 lines, -11 lines 0 comments Download
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-audits-api-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-audits-content-script-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-audits-tests.js View 1 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pfeldman
4 years, 11 months ago (2015-06-05 13:40:40 UTC) #2
caseq
https://codereview.chromium.org/1158723004/diff/1/LayoutTests/inspector/extensions/extensions-audits-expected.txt File LayoutTests/inspector/extensions/extensions-audits-expected.txt (right): https://codereview.chromium.org/1158723004/diff/1/LayoutTests/inspector/extensions/extensions-audits-expected.txt#newcode7 LayoutTests/inspector/extensions/extensions-audits-expected.txt:7: Progress: 88% So when new categories are added to ...
4 years, 11 months ago (2015-06-05 13:46:29 UTC) #3
pfeldman
Done. PTAL
4 years, 11 months ago (2015-06-05 13:53:02 UTC) #4
caseq
lgtm
4 years, 11 months ago (2015-06-05 13:55:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158723004/20001
4 years, 11 months ago (2015-06-05 13:56:07 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2015-06-05 14:52:46 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196578

Powered by Google App Engine
This is Rietveld 408576698