Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1158723003: cq_stats: only take into account attempts within current date range (Closed)

Created:
5 years, 7 months ago by Paweł Hajdan Jr.
Modified:
5 years, 7 months ago
Reviewers:
Adrian Kuegel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

cq_stats: only take into account attempts within current date range This avoids historical issues and outages affecting current stats, and helps make current regressions and issues more visible, since they're not obscured by the old ones. BUG=none Committed: https://chromium.googlesource.com/infra/infra/+/b7864190186f91567cadbab892ba914a063ca716

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M infra/tools/cq_stats/cq_stats.py View 2 chunks +3 lines, -3 lines 0 comments Download
M infra/tools/cq_stats/test/cq_stats_test.py View 4 chunks +16 lines, -10 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
Paweł Hajdan Jr.
5 years, 7 months ago (2015-05-26 09:35:45 UTC) #2
Adrian Kuegel
Sorry for not replying sooner. LGTM with nit. https://codereview.chromium.org/1158723003/diff/1/infra/tools/cq_stats/test/cq_stats_test.py File infra/tools/cq_stats/test/cq_stats_test.py (right): https://codereview.chromium.org/1158723003/diff/1/infra/tools/cq_stats/test/cq_stats_test.py#newcode372 infra/tools/cq_stats/test/cq_stats_test.py:372: def ...
5 years, 7 months ago (2015-05-26 14:40:47 UTC) #3
Paweł Hajdan Jr.
https://codereview.chromium.org/1158723003/diff/1/infra/tools/cq_stats/test/cq_stats_test.py File infra/tools/cq_stats/test/cq_stats_test.py (right): https://codereview.chromium.org/1158723003/diff/1/infra/tools/cq_stats/test/cq_stats_test.py#newcode372 infra/tools/cq_stats/test/cq_stats_test.py:372: def mock_derive_patch_stats(_begin_date, _end_date, patch_id): On 2015/05/26 14:40:47, Adrian Kuegel ...
5 years, 7 months ago (2015-05-27 09:19:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158723003/1
5 years, 7 months ago (2015-05-27 09:20:11 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 09:24:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/b7864190186f91567cadbab892ba9...

Powered by Google App Engine
This is Rietveld 408576698