Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1158713007: [Effen] Fork components/ since we'll be updating all the components before we're done. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] Fork components/ since we'll be updating all the components before we're done. Eventually this'll be merged back into components/, but we want to keep both running for now. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2a7f1197ce01f19083f8d9b3c2f2938276809e87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-23 lines, --23 lines) Patch
A + sky/sdk/lib/framework/components2/animated_component.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/button.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/button_base.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/checkbox.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/drawer.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/drawer_header.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/fixed_height_scrollable.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/floating_action_button.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/icon.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/icon_button.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/ink_splash.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/ink_well.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/input.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/material.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/menu_divider.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/menu_item.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/modal_overlay.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/popup_menu.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/popup_menu_item.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/radio.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/scaffold.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/scrollable.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/lib/framework/components2/tool_bar.dart View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 6 months ago (2015-05-27 15:49:21 UTC) #2
Hixie
5 years, 6 months ago (2015-05-27 15:50:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2a7f1197ce01f19083f8d9b3c2f2938276809e87 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698