Issue 1158713005: Remove the FrameSizeLocals field which appears to be unused (write-only).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1158713005: Remove the FrameSizeLocals field which appears to be unused (write-only). (Closed)

Created:
5 years, 7 months ago by jvoung (off chromium)

Modified:
5 years, 7 months ago

Reviewers:
Karl, Jim Stichnoth, Mircea Trofin

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove the FrameSizeLocals field which appears to be unused (write-only). Might have gotten replaced by some other field, but don't quite remember. Spotted while looking for ways to share the addProlog() code between targets. BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=0d9faeac3449f49acadd021a273257bb3426d379

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	src/IceTargetLoweringX8632.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	src/IceTargetLoweringX8632.cpp	View		2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

jvoung (off chromium)

5 years, 7 months ago (2015-05-27 17:04:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0d9faeac3449f49acadd021a273257bb3426d379 (presubmit successful).