Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2911)

Unified Diff: extensions/browser/api/declarative/rules_registry_service.h

Issue 1158693006: Create a mechanism define declarative rules via the extension manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add thread safety to extensionregistry notifications Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/declarative/rules_registry_service.h
diff --git a/extensions/browser/api/declarative/rules_registry_service.h b/extensions/browser/api/declarative/rules_registry_service.h
index 5cb534b1677d3ce28426285668abad637329efb5..f03adbad7f5b3f1ade92989e3b8879e86e7d0e32 100644
--- a/extensions/browser/api/declarative/rules_registry_service.h
+++ b/extensions/browser/api/declarative/rules_registry_service.h
@@ -88,7 +88,7 @@ class RulesRegistryService : public BrowserContextKeyedAPI,
}
// For testing.
- void SimulateExtensionUninstalled(const std::string& extension_id);
+ void SimulateExtensionUninstalled(const Extension* extension);
private:
friend class BrowserContextKeyedAPIFactory<RulesRegistryService>;
@@ -109,12 +109,12 @@ class RulesRegistryService : public BrowserContextKeyedAPI,
extensions::UninstallReason reason) override;
// Iterates over all registries, and calls |notification_callback| on them
- // with |extension_id| as the argument. If a registry lives on a different
+ // with |extension| as the argument. If a registry lives on a different
// thread, the call is posted to that thread, so no guarantee of synchronous
// processing.
void NotifyRegistriesHelper(
- void (RulesRegistry::*notification_callback)(const std::string&),
- const std::string& extension_id);
+ void (RulesRegistry::*notification_callback)(const Extension*),
+ const Extension* extension);
// BrowserContextKeyedAPI implementation.
static const char* service_name() {
« no previous file with comments | « extensions/browser/api/declarative/rules_registry.cc ('k') | extensions/browser/api/declarative/rules_registry_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698