Index: extensions/common/api/declarative/declarative_manifest_unittest.cc |
diff --git a/extensions/common/api/declarative/declarative_manifest_unittest.cc b/extensions/common/api/declarative/declarative_manifest_unittest.cc |
new file mode 100644 |
index 0000000000000000000000000000000000000000..bfdd41b032d9e936a7d885b93bbf5729de33a03b |
--- /dev/null |
+++ b/extensions/common/api/declarative/declarative_manifest_unittest.cc |
@@ -0,0 +1,182 @@ |
+// Copyright 2015 The Chromium Authors. All rights reserved. |
+// Use of this source code is governed by a BSD-style license that can be |
+// found in the LICENSE file. |
+ |
+#include "extensions/browser/api_test_utils.h" |
+#include "extensions/common/api/declarative/declarative_manifest_data.h" |
+#include "extensions/common/manifest_test.h" |
+ |
+namespace extensions { |
+ |
+using api_test_utils::ParseDictionary; |
+using DeclarativeManifestTest = ManifestTest; |
+ |
+TEST_F(DeclarativeManifestTest, Valid) { |
+ scoped_refptr<Extension> extension = LoadAndExpectSuccess("event_rules.json"); |
+ DeclarativeManifestData* manifest_data = |
+ DeclarativeManifestData::Get(extension.get()); |
+ ASSERT_TRUE(manifest_data); |
+ std::vector<linked_ptr<DeclarativeManifestData::Rule>>& rules = |
+ manifest_data->RulesForEvent("foo"); |
+ EXPECT_EQ(1u, rules.size()); |
+ scoped_ptr<base::DictionaryValue> expected_rule = ParseDictionary( |
+ "{" |
+ " \"actions\": [{" |
+ " \"instanceType\": \"action_type\"" |
+ " }]," |
+ " \"conditions\" : [{" |
+ " \"instanceType\" : \"condition_type\"" |
+ " }]" |
+ "}"); |
+ EXPECT_TRUE(expected_rule->Equals(rules[0]->ToValue().get())); |
+} |
+ |
+TEST_F(DeclarativeManifestTest, ConditionMissingType) { |
+ // Create extension |
+ scoped_ptr<base::DictionaryValue> manifest_data = ParseDictionary( |
+ "{" |
+ " \"name\": \"Test\"," |
+ " \"version\": \"1\"," |
+ " \"event_rules\": [" |
+ " {" |
+ " \"event\": \"declarativeContent.onPageChanged\"," |
+ " \"actions\": [{" |
+ " \"type\": \"declarativeContent.ShowPageAction\"" |
+ " }]," |
+ " \"conditions\" : [{" |
+ " \"css\": [\"video\"]" |
+ " }]" |
+ " }" |
+ " ]" |
+ "}"); |
+ ManifestData manifest(manifest_data.get(), "test"); |
+ LoadAndExpectError(manifest, "'type' is required; rule failed to populate"); |
+} |
+ |
+TEST_F(DeclarativeManifestTest, ConditionNotDictionary) { |
+ // Create extension |
+ scoped_ptr<base::DictionaryValue> manifest_data = ParseDictionary( |
+ "{" |
+ " \"name\": \"Test\"," |
+ " \"version\": \"1\"," |
+ " \"event_rules\": [" |
+ " {" |
+ " \"event\": \"declarativeContent.onPageChanged\"," |
+ " \"actions\": [{" |
+ " \"type\": \"declarativeContent.ShowPageAction\"" |
+ " }]," |
+ " \"conditions\" : [true]" |
+ " }" |
+ " ]" |
+ "}"); |
+ ManifestData manifest(manifest_data.get(), "test"); |
+ LoadAndExpectError( |
+ manifest, "expected dictionary, got boolean; rule failed to populate"); |
+} |
+ |
+TEST_F(DeclarativeManifestTest, ActionMissingType) { |
+ // Create extension |
+ scoped_ptr<base::DictionaryValue> manifest_data = ParseDictionary( |
+ "{" |
+ " \"name\": \"Test\"," |
+ " \"version\": \"1\"," |
+ " \"event_rules\": [" |
+ " {" |
+ " \"event\": \"declarativeContent.onPageChanged\"," |
+ " \"actions\": [{}]," |
+ " \"conditions\" : [{" |
+ " \"css\": [\"video\"]," |
+ " \"type\" : \"declarativeContent.PageStateMatcher\"" |
+ " }]" |
+ " }" |
+ " ]" |
+ "}"); |
+ ManifestData manifest(manifest_data.get(), "test"); |
+ LoadAndExpectError(manifest, "'type' is required; rule failed to populate"); |
+} |
+ |
+TEST_F(DeclarativeManifestTest, ActionNotDictionary) { |
+ // Create extension |
+ scoped_ptr<base::DictionaryValue> manifest_data = ParseDictionary( |
+ "{" |
+ " \"name\": \"Test\"," |
+ " \"version\": \"1\"," |
+ " \"event_rules\": [" |
+ " {" |
+ " \"event\": \"declarativeContent.onPageChanged\"," |
+ " \"actions\": [[]]," |
+ " \"conditions\" : [{" |
+ " \"css\": [\"video\"]," |
+ " \"type\" : \"declarativeContent.PageStateMatcher\"" |
+ " }]" |
+ " }" |
+ " ]" |
+ "}"); |
+ ManifestData manifest(manifest_data.get(), "test"); |
+ LoadAndExpectError(manifest, |
+ "expected dictionary, got list; rule failed to populate"); |
+} |
+ |
+TEST_F(DeclarativeManifestTest, EventRulesNotList) { |
+ // Create extension |
+ scoped_ptr<base::DictionaryValue> manifest_data = ParseDictionary( |
+ "{" |
+ " \"name\": \"Test\"," |
+ " \"version\": \"1\"," |
+ " \"event_rules\": {}" |
+ "}"); |
+ ManifestData manifest(manifest_data.get(), "test"); |
+ LoadAndExpectError(manifest, "'event_rules' expected list, got dictionary"); |
+} |
+ |
+TEST_F(DeclarativeManifestTest, EventRuleNotDictionary) { |
+ // Create extension |
+ scoped_ptr<base::DictionaryValue> manifest_data = ParseDictionary( |
+ "{" |
+ " \"name\": \"Test\"," |
+ " \"version\": \"1\"," |
+ " \"event_rules\": [0,1,2]" |
+ "}"); |
+ ManifestData manifest(manifest_data.get(), "test"); |
+ LoadAndExpectError(manifest, "expected dictionary, got integer"); |
+} |
+ |
+TEST_F(DeclarativeManifestTest, EventMissingFromRule) { |
+ // Create extension |
+ scoped_ptr<base::DictionaryValue> manifest_data = ParseDictionary( |
+ "{" |
+ " \"name\": \"Test\"," |
+ " \"version\": \"1\"," |
+ " \"event_rules\": [" |
+ " {" |
+ " \"actions\": [{" |
+ " \"type\": \"declarativeContent.ShowPageAction\"" |
+ " }]," |
+ " \"conditions\" : [{" |
+ " \"css\": [\"video\"]," |
+ " \"type\" : \"declarativeContent.PageStateMatcher\"" |
+ " }]" |
+ " }" |
+ " ]" |
+ "}"); |
+ ManifestData manifest(manifest_data.get(), "test"); |
+ LoadAndExpectError(manifest, "'event' is required"); |
+} |
+ |
+TEST_F(DeclarativeManifestTest, RuleFailedToPopulate) { |
+ // Create extension |
+ scoped_ptr<base::DictionaryValue> manifest_data = ParseDictionary( |
+ "{" |
+ " \"name\": \"Test\"," |
+ " \"version\": \"1\"," |
+ " \"event_rules\": [" |
+ " {" |
+ " \"event\": \"declarativeContent.onPageChanged\"" |
+ " }" |
+ " ]" |
+ "}"); |
+ ManifestData manifest(manifest_data.get(), "test"); |
+ LoadAndExpectError(manifest, "rule failed to populate"); |
+} |
+ |
+} // namespace extensions |