extensions/browser/api/declarative/declarative_api.cc - Issue 1158693006: Create a mechanism define declarative rules via the extension manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative/declarative_api.cc

Issue 1158693006: Create a mechanism define declarative rules via the extension manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/_manifest_features.json ('k') | extensions/browser/api/declarative/rules_registry.h » ('j') | extensions/browser/api/declarative/rules_registry.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative/declarative_api.cc

diff --git a/extensions/browser/api/declarative/declarative_api.cc b/extensions/browser/api/declarative/declarative_api.cc

index bb70fd88b882eaab4a7d57f9c3602e6fc192e91a..ff455b06946b6d265c50718fe47d9d74beff49f0 100644

--- a/extensions/browser/api/declarative/declarative_api.cc

+++ b/extensions/browser/api/declarative/declarative_api.cc

@@ -170,7 +170,7 @@ bool EventsEventAddRulesFunction::RunAsyncOnCorrectThread() {

scoped_ptr<AddRules::Params> params(AddRules::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

- error_ = rules_registry_->AddRules(extension_id(), params->rules);

+ error_ = rules_registry_->AddRules(extension_id(), params->rules, false);

if (error_.empty())

results_ = AddRules::Results::Create(params->rules);