chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc - Issue 1158693006: Create a mechanism define declarative rules via the extension manifest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

Issue 1158693006: Create a mechanism define declarative rules via the extension manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc ('k') | chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc » ('j') | extensions/browser/api/declarative/rules_registry.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

index e0cb6cc640dc7b12a5a54dad167a6e02694da7bc..9040a906bc126dd5ed83b627c526c0eaafca8b56 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

@@ -76,7 +76,7 @@ class RulesRegistryWithCacheTest : public testing::Test {

std::vector<linked_ptr<RulesRegistry::Rule> > add_rules;

add_rules.push_back(make_linked_ptr(new RulesRegistry::Rule));

add_rules[0]->id.reset(new std::string(rule_id));

- return registry->AddRules(extension_id, add_rules);

+ return registry->AddRules(extension_id, add_rules, false);

}

std::string AddRule(const std::string& extension_id,

@@ -220,7 +220,7 @@ TEST_F(RulesRegistryWithCacheTest, OnExtensionUninstalled) {

EXPECT_EQ("", AddRule(extension2_->id(), kRuleId));

// Check that the correct rules are removed.

- registry_->OnExtensionUninstalled(extension1_->id());

+ registry_->OnExtensionUninstalled(extension1_.get());

EXPECT_EQ(0, GetNumberOfRules(extension1_->id()));

EXPECT_EQ(1, GetNumberOfRules(extension2_->id()));

}