Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: extensions/common/api/events.json

Issue 1158693006: Create a mechanism define declarative rules via the extension manifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Prevent removal of rules set in manifest. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/api/events.json
diff --git a/extensions/common/api/events.json b/extensions/common/api/events.json
index e62ea09c68e4a7542b51202de0d59f6dd3af941f..1e830d2d2a42304f91d59d0e8c0f92843c0a2888 100644
--- a/extensions/common/api/events.json
+++ b/extensions/common/api/events.json
@@ -20,6 +20,11 @@
"optional": true,
"description": "Optional identifier that allows referencing this rule."
},
+ "removable": {
not at google - send to devlin 2015/06/04 17:58:49 This shouldn't be part of the public API, instead,
danduong 2015/06/04 19:10:59 Which internal data-structure. Part of the reason
not at google - send to devlin 2015/06/04 19:23:53 However rules are implemented in C++. you're chang
danduong 2015/06/04 21:39:40 Done.
+ "type": "boolean",
+ "optional": true,
+ "description": "False if the rule is not programmatically removable."
+ },
"tags": {
"type": "array",
"items": {"type": "string"},

Powered by Google App Engine
This is Rietveld 408576698