Source/web/RotationViewportAnchor.cpp - Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/RotationViewportAnchor.cpp

Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/RotationViewportAnchor.cpp

diff --git a/Source/web/RotationViewportAnchor.cpp b/Source/web/RotationViewportAnchor.cpp

index c5c03e0568589d142d380d3d9ea607f0a764d2d7..d2bc0a5d073fa354d15a889891057dada896745e 100644

--- a/Source/web/RotationViewportAnchor.cpp

+++ b/Source/web/RotationViewportAnchor.cpp

@@ -160,7 +160,7 @@ void RotationViewportAnchor::restoreToAnchor()

computeOrigins(pinchViewportSize, mainFrameOrigin, pinchViewportOrigin);

- m_rootFrameView->setScrollOffset(mainFrameOrigin);

+ m_rootFrameView->setScrollPosition(mainFrameOrigin, ProgrammaticScroll);

// Set scale before location, since location can be clamped on setting scale.

m_pinchViewport->setScale(newPageScaleFactor);

« Source/platform/scroll/ScrollableArea.cpp ('K') | « Source/web/ResizeViewportAnchor.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »