Source/modules/accessibility/AXScrollbar.cpp - Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXScrollbar.cpp

Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp ('K') | « Source/modules/accessibility/AXObject.cpp ('k') | Source/platform/graphics/GraphicsLayer.cpp » ('j') | Source/platform/mac/ScrollAnimatorMac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXScrollbar.cpp

diff --git a/Source/modules/accessibility/AXScrollbar.cpp b/Source/modules/accessibility/AXScrollbar.cpp

index ded75fc27840200183b2ea38bae07b964983195d..32112335b3ddd5a78b2ef390a0ffda2a073dcc4b 100644

--- a/Source/modules/accessibility/AXScrollbar.cpp

+++ b/Source/modules/accessibility/AXScrollbar.cpp

@@ -106,7 +106,7 @@ void AXScrollbar::setValue(float value)

return;

float newValue = value * m_scrollbar->maximum();

- m_scrollbar->scrollableArea()->scrollToOffsetWithoutAnimation(m_scrollbar->orientation(), newValue);

+ m_scrollbar->scrollableArea()->setScrollPositionSingleAxis(m_scrollbar->orientation(), newValue, ProgrammaticScroll);

}

} // namespace blink