Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: Source/core/dom/Element.cpp

Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/FrameView.h » ('j') | Source/core/frame/LocalFrame.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Element.cpp
diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp
index a6b1b85232e3b8038577ec7f9c3ea8d490df99d1..b594ce529008d9a58033472ed9f80d758574a00f 100644
--- a/Source/core/dom/Element.cpp
+++ b/Source/core/dom/Element.cpp
@@ -881,7 +881,7 @@ void Element::scrollFrameBy(const ScrollToOptions& scrollToOptions)
double newScaledLeft = left * frame->pageZoomFactor() + view->scrollPositionDouble().x();
double newScaledTop = top * frame->pageZoomFactor() + view->scrollPositionDouble().y();
- view->setScrollPosition(DoublePoint(newScaledLeft, newScaledTop), scrollBehavior);
+ view->setScrollPosition(DoublePoint(newScaledLeft, newScaledTop), ProgrammaticScroll, scrollBehavior);
}
void Element::scrollFrameTo(const ScrollToOptions& scrollToOptions)
@@ -901,7 +901,7 @@ void Element::scrollFrameTo(const ScrollToOptions& scrollToOptions)
scaledLeft = ScrollableArea::normalizeNonFiniteScroll(scrollToOptions.left()) * frame->pageZoomFactor();
if (scrollToOptions.hasTop())
scaledTop = ScrollableArea::normalizeNonFiniteScroll(scrollToOptions.top()) * frame->pageZoomFactor();
- view->setScrollPosition(DoublePoint(scaledLeft, scaledTop), scrollBehavior);
+ view->setScrollPosition(DoublePoint(scaledLeft, scaledTop), ProgrammaticScroll, scrollBehavior);
}
void Element::incrementProxyCount()
« no previous file with comments | « no previous file | Source/core/frame/FrameView.h » ('j') | Source/core/frame/LocalFrame.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698