Source/platform/scroll/ScrollableAreaTest.cpp - Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/scroll/ScrollableAreaTest.cpp

Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Build fix Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/scroll/ScrollableAreaTest.cpp

diff --git a/Source/platform/scroll/ScrollableAreaTest.cpp b/Source/platform/scroll/ScrollableAreaTest.cpp

index 68794648ae04333b0c68e583f7e9d7ba2d42089d..d5b52199b8d34da57cda11081868f063f39cad91 100644

--- a/Source/platform/scroll/ScrollableAreaTest.cpp

+++ b/Source/platform/scroll/ScrollableAreaTest.cpp

@@ -38,7 +38,7 @@ public:

virtual bool userInputScrollable(ScrollbarOrientation) const override { return true; }

virtual bool shouldPlaceVerticalScrollbarOnLeft() const override { return false; }

- virtual void setScrollOffset(const IntPoint& offset) override { m_scrollPosition = offset.shrunkTo(m_maximumScrollPosition); }

+ virtual void setScrollOffset(const IntPoint& offset, ScrollType) override { m_scrollPosition = offset.shrunkTo(m_maximumScrollPosition); }

virtual IntPoint scrollPosition() const override { return m_scrollPosition; }

virtual IntPoint maximumScrollPosition() const override { return m_maximumScrollPosition; }

virtual int visibleHeight() const override { return 768; }

« no previous file with comments | « Source/platform/scroll/ScrollableArea.cpp ('k') | Source/platform/scroll/Scrollbar.cpp » ('j') | no next file with comments »