Source/core/frame/PinchViewport.h - Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/PinchViewport.h

Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Build fix Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/PinchViewport.h

diff --git a/Source/core/frame/PinchViewport.h b/Source/core/frame/PinchViewport.h

index c034a1fc681d0ed8a4423af3eadd0420c82e821c..69871ffa41720f1148a973251aed45a20dcd98b6 100644

--- a/Source/core/frame/PinchViewport.h

+++ b/Source/core/frame/PinchViewport.h

@@ -182,8 +182,8 @@ public:

virtual bool shouldPlaceVerticalScrollbarOnLeft() const override { return false; }

virtual void invalidateScrollbarRect(Scrollbar*, const IntRect&) override;

virtual void invalidateScrollCornerRect(const IntRect&) override { }

- virtual void setScrollOffset(const IntPoint&) override;

- virtual void setScrollOffset(const DoublePoint&) override;

+ virtual void setScrollOffset(const IntPoint&, ScrollType) override;

+ virtual void setScrollOffset(const DoublePoint&, ScrollType) override;

virtual GraphicsLayer* layerForContainer() const override;

virtual GraphicsLayer* layerForScrolling() const override;

virtual GraphicsLayer* layerForHorizontalScrollbar() const override;

« no previous file with comments | « Source/core/frame/LocalFrame.cpp ('k') | Source/core/frame/PinchViewport.cpp » ('j') | no next file with comments »