Source/modules/accessibility/AXScrollbar.cpp - Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/accessibility/AXScrollbar.cpp

Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp ('K') | « Source/modules/accessibility/AXObject.cpp ('k') | Source/platform/graphics/GraphicsLayer.cpp » ('j') | Source/platform/mac/ScrollAnimatorMac.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Apple Inc. All rights reserved.	2 * Copyright (C) 2010 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 88 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
99	99

100 void AXScrollbar::setValue(float value)	100 void AXScrollbar::setValue(float value)

101 {	101 {

102 if (!m_scrollbar)	102 if (!m_scrollbar)

103 return;	103 return;

104	104

105 if (!m_scrollbar->scrollableArea())	105 if (!m_scrollbar->scrollableArea())

106 return;	106 return;

107	107

108 float newValue = value * m_scrollbar->maximum();	108 float newValue = value * m_scrollbar->maximum();

109 m_scrollbar->scrollableArea()->scrollToOffsetWithoutAnimation(m_scrollbar->o rientation(), newValue);	109 m_scrollbar->scrollableArea()->setScrollPositionSingleAxis(m_scrollbar->orie ntation(), newValue, ProgrammaticScroll);

110 }	110 }

111	111

112 } // namespace blink	112 } // namespace blink

OLD	NEW