Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: Source/core/paint/DeprecatedPaintLayerScrollableArea.h

Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Build fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 virtual void invalidateScrollCornerRect(const IntRect&) override; 87 virtual void invalidateScrollCornerRect(const IntRect&) override;
88 virtual bool shouldUseIntegerScrollOffset() const override; 88 virtual bool shouldUseIntegerScrollOffset() const override;
89 virtual bool isActive() const override; 89 virtual bool isActive() const override;
90 virtual bool isScrollCornerVisible() const override; 90 virtual bool isScrollCornerVisible() const override;
91 virtual IntRect scrollCornerRect() const override; 91 virtual IntRect scrollCornerRect() const override;
92 virtual IntRect convertFromScrollbarToContainingView(const Scrollbar*, const IntRect&) const override; 92 virtual IntRect convertFromScrollbarToContainingView(const Scrollbar*, const IntRect&) const override;
93 virtual IntRect convertFromContainingViewToScrollbar(const Scrollbar*, const IntRect&) const override; 93 virtual IntRect convertFromContainingViewToScrollbar(const Scrollbar*, const IntRect&) const override;
94 virtual IntPoint convertFromScrollbarToContainingView(const Scrollbar*, cons t IntPoint&) const override; 94 virtual IntPoint convertFromScrollbarToContainingView(const Scrollbar*, cons t IntPoint&) const override;
95 virtual IntPoint convertFromContainingViewToScrollbar(const Scrollbar*, cons t IntPoint&) const override; 95 virtual IntPoint convertFromContainingViewToScrollbar(const Scrollbar*, cons t IntPoint&) const override;
96 virtual int scrollSize(ScrollbarOrientation) const override; 96 virtual int scrollSize(ScrollbarOrientation) const override;
97 virtual void setScrollOffset(const IntPoint&) override;
98 virtual void setScrollOffset(const DoublePoint&) override;
99 virtual IntPoint scrollPosition() const override; 97 virtual IntPoint scrollPosition() const override;
100 virtual DoublePoint scrollPositionDouble() const override; 98 virtual DoublePoint scrollPositionDouble() const override;
101 virtual IntPoint minimumScrollPosition() const override; 99 virtual IntPoint minimumScrollPosition() const override;
102 virtual IntPoint maximumScrollPosition() const override; 100 virtual IntPoint maximumScrollPosition() const override;
103 virtual IntRect visibleContentRect(IncludeScrollbarsInRect = ExcludeScrollba rs) const override; 101 virtual IntRect visibleContentRect(IncludeScrollbarsInRect = ExcludeScrollba rs) const override;
104 virtual int visibleHeight() const override; 102 virtual int visibleHeight() const override;
105 virtual int visibleWidth() const override; 103 virtual int visibleWidth() const override;
106 virtual IntSize contentsSize() const override; 104 virtual IntSize contentsSize() const override;
107 virtual IntPoint lastKnownMousePosition() const override; 105 virtual IntPoint lastKnownMousePosition() const override;
108 virtual bool scrollAnimatorEnabled() const override; 106 virtual bool scrollAnimatorEnabled() const override;
109 virtual bool shouldSuspendScrollAnimations() const override; 107 virtual bool shouldSuspendScrollAnimations() const override;
110 virtual bool scrollbarsCanBeActive() const override; 108 virtual bool scrollbarsCanBeActive() const override;
111 virtual IntRect scrollableAreaBoundingBox() const override; 109 virtual IntRect scrollableAreaBoundingBox() const override;
112 virtual void registerForAnimation() override; 110 virtual void registerForAnimation() override;
113 virtual void deregisterForAnimation() override; 111 virtual void deregisterForAnimation() override;
114 virtual bool userInputScrollable(ScrollbarOrientation) const override; 112 virtual bool userInputScrollable(ScrollbarOrientation) const override;
115 virtual bool shouldPlaceVerticalScrollbarOnLeft() const override; 113 virtual bool shouldPlaceVerticalScrollbarOnLeft() const override;
116 virtual int pageStep(ScrollbarOrientation) const override; 114 virtual int pageStep(ScrollbarOrientation) const override;
115 virtual ScrollBehavior scrollBehaviorStyle() const override;
117 116
118 double scrollXOffset() const { return m_scrollOffset.width() + scrollOrigin( ).x(); } 117 double scrollXOffset() const { return m_scrollOffset.width() + scrollOrigin( ).x(); }
119 double scrollYOffset() const { return m_scrollOffset.height() + scrollOrigin ().y(); } 118 double scrollYOffset() const { return m_scrollOffset.height() + scrollOrigin ().y(); }
120 119
121 DoubleSize scrollOffset() const { return m_scrollOffset; } 120 DoubleSize scrollOffset() const { return m_scrollOffset; }
122 121
123 // FIXME: We shouldn't allow access to m_overflowRect outside this class. 122 // FIXME: We shouldn't allow access to m_overflowRect outside this class.
124 LayoutRect overflowRect() const { return m_overflowRect; } 123 LayoutRect overflowRect() const { return m_overflowRect; }
125 124
126 void scrollToOffset(const DoubleSize& scrollOffset, ScrollOffsetClamping = S crollOffsetUnclamped, ScrollBehavior = ScrollBehaviorInstant); 125 void scrollToOffset(const DoubleSize& scrollOffset, ScrollOffsetClamping = S crollOffsetUnclamped, ScrollBehavior = ScrollBehaviorInstant);
127 126
128 void scrollToXOffset(double x, ScrollOffsetClamping clamp = ScrollOffsetUncl amped, ScrollBehavior scrollBehavior = ScrollBehaviorInstant) 127 void scrollToXOffset(double x, ScrollOffsetClamping clamp = ScrollOffsetUncl amped, ScrollBehavior scrollBehavior = ScrollBehaviorInstant)
129 { 128 {
130 scrollToOffset(DoubleSize(x, scrollYOffset()), clamp, scrollBehavior); 129 scrollToOffset(DoubleSize(x, scrollYOffset()), clamp, scrollBehavior);
131 } 130 }
132 131
133 void scrollToYOffset(double y, ScrollOffsetClamping clamp = ScrollOffsetUncl amped, ScrollBehavior scrollBehavior = ScrollBehaviorInstant) 132 void scrollToYOffset(double y, ScrollOffsetClamping clamp = ScrollOffsetUncl amped, ScrollBehavior scrollBehavior = ScrollBehaviorInstant)
134 { 133 {
135 scrollToOffset(DoubleSize(scrollXOffset(), y), clamp, scrollBehavior); 134 scrollToOffset(DoubleSize(scrollXOffset(), y), clamp, scrollBehavior);
136 } 135 }
137 136
138 virtual void setScrollPosition(const DoublePoint& position, ScrollBehavior s crollBehavior = ScrollBehaviorInstant) override 137 virtual void setScrollPosition(const DoublePoint& position, ScrollType scrol lType, ScrollBehavior scrollBehavior = ScrollBehaviorInstant) override
139 { 138 {
140 scrollToOffset(toDoubleSize(position), ScrollOffsetClamped, scrollBehavi or); 139 scrollToOffset(toDoubleSize(position), ScrollOffsetClamped, scrollBehavi or);
141 } 140 }
142 141
143 void updateAfterLayout(); 142 void updateAfterLayout();
144 void updateAfterStyleChange(const ComputedStyle*); 143 void updateAfterStyleChange(const ComputedStyle*);
145 void updateAfterOverflowRecalc(); 144 void updateAfterOverflowRecalc();
146 145
147 virtual bool updateAfterCompositingChange() override; 146 virtual bool updateAfterCompositingChange() override;
148 147
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 DeprecatedPaintLayer* layer() const; 208 DeprecatedPaintLayer* layer() const;
210 209
211 LayoutScrollbarPart* resizer() { return m_resizer; } 210 LayoutScrollbarPart* resizer() { return m_resizer; }
212 211
213 const IntPoint& cachedOverlayScrollbarOffset() { return m_cachedOverlayScrol lbarOffset; } 212 const IntPoint& cachedOverlayScrollbarOffset() { return m_cachedOverlayScrol lbarOffset; }
214 void setCachedOverlayScrollbarOffset(const IntPoint& offset) { m_cachedOverl ayScrollbarOffset = offset; } 213 void setCachedOverlayScrollbarOffset(const IntPoint& offset) { m_cachedOverl ayScrollbarOffset = offset; }
215 214
216 IntRect rectForHorizontalScrollbar(const IntRect& borderBoxRect) const; 215 IntRect rectForHorizontalScrollbar(const IntRect& borderBoxRect) const;
217 IntRect rectForVerticalScrollbar(const IntRect& borderBoxRect) const; 216 IntRect rectForVerticalScrollbar(const IntRect& borderBoxRect) const;
218 217
219 protected:
220 virtual ScrollBehavior scrollBehaviorStyle() const override;
221
222 private: 218 private:
223 bool hasHorizontalOverflow() const; 219 bool hasHorizontalOverflow() const;
224 bool hasVerticalOverflow() const; 220 bool hasVerticalOverflow() const;
225 bool hasScrollableHorizontalOverflow() const; 221 bool hasScrollableHorizontalOverflow() const;
226 bool hasScrollableVerticalOverflow() const; 222 bool hasScrollableVerticalOverflow() const;
227 223
228 void computeScrollDimensions(); 224 void computeScrollDimensions();
229 225
230 DoubleSize clampScrollOffset(const DoubleSize&) const; 226 DoubleSize clampScrollOffset(const DoubleSize&) const;
231 227
228 virtual void setScrollOffset(const IntPoint&, ScrollType) override;
229 virtual void setScrollOffset(const DoublePoint&, ScrollType) override;
232 230
233 LayoutUnit verticalScrollbarStart(int minX, int maxX) const; 231 LayoutUnit verticalScrollbarStart(int minX, int maxX) const;
234 LayoutUnit horizontalScrollbarStart(int minX) const; 232 LayoutUnit horizontalScrollbarStart(int minX) const;
235 IntSize scrollbarOffset(const Scrollbar*) const; 233 IntSize scrollbarOffset(const Scrollbar*) const;
236 234
237 PassRefPtrWillBeRawPtr<Scrollbar> createScrollbar(ScrollbarOrientation); 235 PassRefPtrWillBeRawPtr<Scrollbar> createScrollbar(ScrollbarOrientation);
238 void destroyScrollbar(ScrollbarOrientation); 236 void destroyScrollbar(ScrollbarOrientation);
239 237
240 void setHasHorizontalScrollbar(bool hasScrollbar); 238 void setHasHorizontalScrollbar(bool hasScrollbar);
241 void setHasVerticalScrollbar(bool hasScrollbar); 239 void setHasVerticalScrollbar(bool hasScrollbar);
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 // LayoutObject to hold our custom scroll corner. 280 // LayoutObject to hold our custom scroll corner.
283 LayoutScrollbarPart* m_scrollCorner; 281 LayoutScrollbarPart* m_scrollCorner;
284 282
285 // LayoutObject to hold our custom resizer. 283 // LayoutObject to hold our custom resizer.
286 LayoutScrollbarPart* m_resizer; 284 LayoutScrollbarPart* m_resizer;
287 }; 285 };
288 286
289 } // namespace blink 287 } // namespace blink
290 288
291 #endif // LayerScrollableArea_h 289 #endif // LayerScrollableArea_h
OLDNEW
« no previous file with comments | « Source/core/page/SpatialNavigation.cpp ('k') | Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698