Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: Source/core/page/SpatialNavigation.cpp

Issue 1158673006: Replace various ScrollableArea scroll methods with setScrollPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Build fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Nokia Corporation and/or its subsidiary(-ies) 2 * Copyright (C) 2009 Nokia Corporation and/or its subsidiary(-ies)
3 * Copyright (C) 2009 Antonio Gomes <tonikitoo@webkit.org> 3 * Copyright (C) 2009 Antonio Gomes <tonikitoo@webkit.org>
4 * 4 *
5 * All rights reserved. 5 * All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 dy = - ScrollableArea::pixelsPerLineStep(); 208 dy = - ScrollableArea::pixelsPerLineStep();
209 break; 209 break;
210 case WebFocusTypeDown: 210 case WebFocusTypeDown:
211 dy = ScrollableArea::pixelsPerLineStep(); 211 dy = ScrollableArea::pixelsPerLineStep();
212 break; 212 break;
213 default: 213 default:
214 ASSERT_NOT_REACHED(); 214 ASSERT_NOT_REACHED();
215 return false; 215 return false;
216 } 216 }
217 217
218 frame->view()->scrollBy(IntSize(dx, dy)); 218 frame->view()->scrollBy(IntSize(dx, dy), UserScroll);
219 return true; 219 return true;
220 } 220 }
221 return false; 221 return false;
222 } 222 }
223 223
224 bool scrollInDirection(Node* container, WebFocusType type) 224 bool scrollInDirection(Node* container, WebFocusType type)
225 { 225 {
226 ASSERT(container); 226 ASSERT(container);
227 if (container->isDocumentNode()) 227 if (container->isDocumentNode())
228 return scrollInDirection(toDocument(container)->frame(), type); 228 return scrollInDirection(toDocument(container)->frame(), type);
(...skipping 396 matching lines...) Expand 10 before | Expand all | Expand 10 after
625 LayoutRect rect = virtualRectForDirection(type, rectToAbsoluteCoordinates(ar ea.document().frame(), area.computeRect(area.imageElement()->layoutObject())), 1 ); 625 LayoutRect rect = virtualRectForDirection(type, rectToAbsoluteCoordinates(ar ea.document().frame(), area.computeRect(area.imageElement()->layoutObject())), 1 );
626 return rect; 626 return rect;
627 } 627 }
628 628
629 HTMLFrameOwnerElement* frameOwnerElement(FocusCandidate& candidate) 629 HTMLFrameOwnerElement* frameOwnerElement(FocusCandidate& candidate)
630 { 630 {
631 return candidate.isFrameOwnerElement() ? toHTMLFrameOwnerElement(candidate.v isibleNode) : nullptr; 631 return candidate.isFrameOwnerElement() ? toHTMLFrameOwnerElement(candidate.v isibleNode) : nullptr;
632 }; 632 };
633 633
634 } // namespace blink 634 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutBox.cpp ('k') | Source/core/paint/DeprecatedPaintLayerScrollableArea.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698