runtime/vm/cha_test.cc - Issue 1158673004: Do not eagerly add guarded leaf classes with CHA; do not add them for private names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/cha_test.cc

Issue 1158673004: Do not eagerly add guarded leaf classes with CHA; do not add them for private names. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: a Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/cha_test.cc

diff --git a/runtime/vm/cha_test.cc b/runtime/vm/cha_test.cc

index 3926daa62bc508ac3a43799c15b6fe5943668104..1cd95dc4e306ab9920c2135e55cabf7103618616 100644

--- a/runtime/vm/cha_test.cc

+++ b/runtime/vm/cha_test.cc

@@ -89,7 +89,9 @@ TEST_CASE(ClassHierarchyAnalysis) {

EXPECT(cha.HasSubclasses(class_a));

EXPECT(cha.HasSubclasses(class_b));

EXPECT(!cha.HasSubclasses(class_c));

+ cha.AddToLeafClasses(class_c);

EXPECT(!cha.HasSubclasses(class_d));

+ cha.AddToLeafClasses(class_d);

EXPECT(!ContainsCid(cha.leaf_classes(), class_a.id()));

EXPECT(!ContainsCid(cha.leaf_classes(), class_b.id()));

« no previous file with comments | « runtime/vm/cha.cc ('k') | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »