Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Side by Side Diff: runtime/vm/flow_graph_compiler.cc

Issue 1158673004: Do not eagerly add guarded leaf classes with CHA; do not add them for private names. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: typos in comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX.
6 6
7 #include "vm/flow_graph_compiler.h" 7 #include "vm/flow_graph_compiler.h"
8 8
9 #include "vm/bit_vector.h" 9 #include "vm/bit_vector.h"
10 #include "vm/cha.h" 10 #include "vm/cha.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 DECLARE_FLAG(bool, intrinsify); 52 DECLARE_FLAG(bool, intrinsify);
53 DECLARE_FLAG(bool, load_deferred_eagerly); 53 DECLARE_FLAG(bool, load_deferred_eagerly);
54 DECLARE_FLAG(int, optimization_counter_threshold); 54 DECLARE_FLAG(int, optimization_counter_threshold);
55 DECLARE_FLAG(bool, propagate_ic_data); 55 DECLARE_FLAG(bool, propagate_ic_data);
56 DECLARE_FLAG(int, regexp_optimization_counter_threshold); 56 DECLARE_FLAG(int, regexp_optimization_counter_threshold);
57 DECLARE_FLAG(int, reoptimization_counter_threshold); 57 DECLARE_FLAG(int, reoptimization_counter_threshold);
58 DECLARE_FLAG(int, stacktrace_every); 58 DECLARE_FLAG(int, stacktrace_every);
59 DECLARE_FLAG(charp, stacktrace_filter); 59 DECLARE_FLAG(charp, stacktrace_filter);
60 DECLARE_FLAG(bool, support_debugger); 60 DECLARE_FLAG(bool, support_debugger);
61 DECLARE_FLAG(bool, use_field_guards); 61 DECLARE_FLAG(bool, use_field_guards);
62 DECLARE_FLAG(bool, use_cha); 62 DECLARE_FLAG(bool, use_cha_deopt);
63 DECLARE_FLAG(bool, use_osr); 63 DECLARE_FLAG(bool, use_osr);
64 DECLARE_FLAG(bool, warn_on_javascript_compatibility); 64 DECLARE_FLAG(bool, warn_on_javascript_compatibility);
65 65
66 66
67 static void NooptModeHandler(bool value) { 67 static void NooptModeHandler(bool value) {
68 if (value) { 68 if (value) {
69 FLAG_always_megamorphic_calls = value; 69 FLAG_always_megamorphic_calls = value;
70 FLAG_optimization_counter_threshold = -1; 70 FLAG_optimization_counter_threshold = -1;
71 FLAG_use_field_guards = false; 71 FLAG_use_field_guards = false;
72 FLAG_use_osr = false; 72 FLAG_use_osr = false;
73 FLAG_emit_edge_counters = false; 73 FLAG_emit_edge_counters = false;
74 FLAG_support_debugger = false; 74 FLAG_support_debugger = false;
75 FLAG_ic_range_profiling = false; 75 FLAG_ic_range_profiling = false;
76 FLAG_collect_code = false; 76 FLAG_collect_code = false;
77 FLAG_load_deferred_eagerly = true; 77 FLAG_load_deferred_eagerly = true;
78 FLAG_deoptimize_alot = false; // Used in some tests. 78 FLAG_deoptimize_alot = false; // Used in some tests.
79 FLAG_deoptimize_every = 0; // Used in some tests. 79 FLAG_deoptimize_every = 0; // Used in some tests.
80 FLAG_collect_code = false; 80 FLAG_collect_code = false;
81 Compiler::set_always_optimize(true); 81 Compiler::set_always_optimize(true);
82 Compiler::set_guess_other_cid(false); 82 Compiler::set_guess_other_cid(false);
83 // TODO(srdjan): Enable CHA when eager class finalization is 83 // TODO(srdjan): Enable CHA deoptimization when eager class finalization is
84 // implemented, either with precompilation or as a special pass. 84 // implemented, either with precompilation or as a special pass.
85 FLAG_use_cha = false; 85 FLAG_use_cha_deopt = false;
86 } 86 }
87 } 87 }
88 88
89 89
90 // --noopt disables optimizer and tunes unoptimized code to run as fast 90 // --noopt disables optimizer and tunes unoptimized code to run as fast
91 // as possible. 91 // as possible.
92 DEFINE_FLAG_HANDLER(NooptModeHandler, 92 DEFINE_FLAG_HANDLER(NooptModeHandler,
93 noopt, 93 noopt,
94 "Run fast unoptimized code only."); 94 "Run fast unoptimized code only.");
95 95
(...skipping 1641 matching lines...) Expand 10 before | Expand all | Expand 10 after
1737 1737
1738 1738
1739 void FlowGraphCompiler::FrameStateClear() { 1739 void FlowGraphCompiler::FrameStateClear() {
1740 ASSERT(!is_optimizing()); 1740 ASSERT(!is_optimizing());
1741 frame_state_.TruncateTo(0); 1741 frame_state_.TruncateTo(0);
1742 } 1742 }
1743 #endif 1743 #endif
1744 1744
1745 1745
1746 } // namespace dart 1746 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698