net/http/http_network_session.cc - Issue 1158653002: Returning scoped_ptr instead of raw pointer in SpdySessionPoolInfoToValue() in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_session.cc

Issue 1158653002: Returning scoped_ptr instead of raw pointer in SpdySessionPoolInfoToValue() in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_network_session.cc

diff --git a/net/http/http_network_session.cc b/net/http/http_network_session.cc

index 389ac5213d3fa7ea62bf96305651840bd5ee9b84..af1b92d9d73accdbf524426d0e14a07d67722d48 100644

--- a/net/http/http_network_session.cc

+++ b/net/http/http_network_session.cc

@@ -255,8 +255,8 @@ base::Value* HttpNetworkSession::SocketPoolInfoToValue() const {

return normal_socket_pool_manager_->SocketPoolInfoToValue();

}

-base::Value* HttpNetworkSession::SpdySessionPoolInfoToValue() const {

- return spdy_session_pool_.SpdySessionPoolInfoToValue();

+scoped_ptr<base::Value> HttpNetworkSession::SpdySessionPoolInfoToValue() const {

+ return spdy_session_pool_.SpdySessionPoolInfoToValue().Pass();

eroman 2015/05/26 18:12:39 Remove Pass()

}

base::Value* HttpNetworkSession::QuicInfoToValue() const {

« no previous file with comments | « net/http/http_network_session.h ('k') | net/spdy/spdy_session.h » ('j') | no next file with comments »