Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3721)

Unified Diff: build/config/sanitizers/sanitizers.gni

Issue 1158643002: GN: Build with a custom libc++ when using ASAN, TSAN or MSAN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-instrumented-libraries-prebuilt
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/sanitizers/BUILD.gn ('K') | « build/config/sanitizers/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/sanitizers/sanitizers.gni
diff --git a/build/config/sanitizers/sanitizers.gni b/build/config/sanitizers/sanitizers.gni
index 96e23facf844d224e039816e3e524d8cb27c6fc3..1ee5a33c950452c28df6906b804d71a53f2ec840 100644
--- a/build/config/sanitizers/sanitizers.gni
+++ b/build/config/sanitizers/sanitizers.gni
@@ -12,4 +12,9 @@ declare_args() {
# standard system libraries. Set this flag to download prebuilt binaries from
# GCS.
use_prebuilt_instrumented_libraries = false
+
+ # Use libc++ (buildtools/third_party/libc++ and
+ # buildtools/third_party/libc++abi) instead of stdlibc++ as standard library.
+ # This is intended to use for instrumented builds.
earthdok 2015/05/25 15:28:00 Please fix the wording here ("intended to be used"
Sam McNally 2015/05/26 01:15:00 Done.
+ use_custom_libcxx = (is_asan && is_desktop_linux) || is_tsan || is_msan
Alexander Potapenko 2015/05/25 08:27:18 Is 'is_desktop_linux' in GN the same as 'OS=="linu
Sam McNally 2015/05/25 08:31:22 Yes. It's defined in https://code.google.com/p/chr
earthdok 2015/05/25 15:28:00 This is disabled on CrOS because of GYP-related is
Sam McNally 2015/05/26 01:15:00 Done.
}
« build/config/sanitizers/BUILD.gn ('K') | « build/config/sanitizers/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698