Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1158623003: Just clear semi-space mark bits once before Scavenge (Closed)

Created:
5 years, 6 months ago by sejunho
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Just clear semi-space mark bits once before Scavenge Both PrepareForScavenge and ResetAllocationInfo clear semi-space mark bits before Scavenge. Doing this once is good enough. BUG= Committed: https://crrev.com/0962f980a21629bbe5a58bb9817fb0f99662bac8 Cr-Commit-Position: refs/heads/master@{#28778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M src/heap/heap.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sejunho
Hi Hannes, I fix description this patch, the change is same before: https://codereview.chromium.org/1152523004/
5 years, 6 months ago (2015-05-29 00:58:14 UTC) #2
sejunho
PTAL
5 years, 6 months ago (2015-06-03 00:24:25 UTC) #3
Hannes Payer (out of office)
LGTM, thanks. I updated the description
5 years, 6 months ago (2015-06-03 06:25:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158623003/1
5 years, 6 months ago (2015-06-03 06:25:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 07:09:27 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0962f980a21629bbe5a58bb9817fb0f99662bac8 Cr-Commit-Position: refs/heads/master@{#28778}
5 years, 6 months ago (2015-06-03 07:09:44 UTC) #8
sejunho
5 years, 6 months ago (2015-06-03 07:29:26 UTC) #9
Message was sent while issue was closed.
On 2015/06/03 06:25:20, Hannes Payer wrote:
> LGTM, thanks. I updated the description

Thanks!!!! :)

Powered by Google App Engine
This is Rietveld 408576698