Source/core/layout/compositing/CompositingReasonFinder.cpp - Issue 1158603003: CSS Independent Transform Properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/compositing/CompositingReasonFinder.cpp

Issue 1158603003: CSS Independent Transform Properties (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/compositing/CompositingReasonFinder.cpp

diff --git a/Source/core/layout/compositing/CompositingReasonFinder.cpp b/Source/core/layout/compositing/CompositingReasonFinder.cpp

index 9d25f0ec5dbfd88b91839b23d1f48cbdfb4ddc2c..e05b6573ce124277986ea91339cccbe349a5fc69 100644

--- a/Source/core/layout/compositing/CompositingReasonFinder.cpp

+++ b/Source/core/layout/compositing/CompositingReasonFinder.cpp

@@ -143,7 +143,7 @@ bool CompositingReasonFinder::requiresCompositingForTransform(LayoutObject* layo

{

// Note that we ask the layoutObject if it has a transform, because the style may have transforms,

// but the layoutObject may be an inline that doesn't support them.

- return layoutObject->hasTransformRelatedProperty() && layoutObject->style()->transform().has3DOperation();

+ return layoutObject->hasTransformRelatedProperty() && (layoutObject->style()->transform().has3DOperation() || layoutObject->style()->has3DTransformProperties());

Eric Willigers 2015/06/05 01:58:23 Why not ensure hasTransformRelatedProperty returns

soonm 2015/06/10 04:09:32 hasTransformProperty will return True because I mo

}

CompositingReasons CompositingReasonFinder::nonStyleDeterminedDirectReasons(const DeprecatedPaintLayer* layer) const

« Source/core/css/resolver/StyleBuilderCustom.cpp ('K') | « Source/core/frame/UseCounter.cpp ('k') | Source/core/style/ComputedStyle.h » ('j') | Source/core/style/ComputedStyle.h » ('J')