Source/core/css/resolver/AnimatedStyleBuilder.cpp - Issue 1158603003: CSS Independent Transform Properties

Unified Diff: Source/core/css/resolver/AnimatedStyleBuilder.cpp

Issue 1158603003: CSS Independent Transform Properties (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/parser/CSSPropertyParser.cpp ('K') | « Source/core/css/parser/CSSPropertyParser.cpp ('k') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/resolver/AnimatedStyleBuilder.cpp

diff --git a/Source/core/css/resolver/AnimatedStyleBuilder.cpp b/Source/core/css/resolver/AnimatedStyleBuilder.cpp

index d810f0bf0832edb452b78a5b8e6986bf369fbb45..b59018c5171e240b0a0bd00dd904f67f5b7eb342 100644

--- a/Source/core/css/resolver/AnimatedStyleBuilder.cpp

+++ b/Source/core/css/resolver/AnimatedStyleBuilder.cpp

@@ -597,6 +597,30 @@ void AnimatedStyleBuilder::applyProperty(CSSPropertyID property, StyleResolverSt

style->setTransform(operations.size() ? operations : TransformOperations(true));

return;

}

+ case CSSPropertyTranslate: {

+ const TransformOperations& op = toAnimatableTransform(value)->transformOperations();

+ if (!op.size())

+ return;

Timothy Loh 2015/06/05 00:55:59 unreachable?

Eric Willigers 2015/06/05 01:58:22 Should we clear the translate? Or should we be ass

soonm 2015/06/10 04:09:32 Done.

+ const TranslateTransformOperation* transform = static_cast<const TranslateTransformOperation*>(op.operations().last().get());

+ style->setTranslate(transform->x(), transform->y(), transform->z());

Timothy Loh 2015/06/05 00:55:59 setTranslate(transform)?

soonm 2015/06/10 04:09:32 Done.

+ return;

+ }

+ case CSSPropertyRotate: {

+ const TransformOperations& op = toAnimatableTransform(value)->transformOperations();

+ if (!op.size())

+ return;

+ const RotateTransformOperation* transform = static_cast<const RotateTransformOperation*>(op.operations().last().get());

+ style->setRotate(transform->angle(), transform->x(), transform->y(), transform->z());

Timothy Loh 2015/06/05 00:55:59 setRotate(transform)?

soonm 2015/06/10 04:09:32 Done.

+ return;

+ }

+ case CSSPropertyScale: {

+ const TransformOperations& op = toAnimatableTransform(value)->transformOperations();

+ if (!op.size())

+ return;

+ const ScaleTransformOperation* transform = static_cast<const ScaleTransformOperation*>(op.operations().last().get());

+ style->setScale(transform->x(), transform->y(), transform->z());

+ return;

+ }

case CSSPropertyTransformOrigin:

style->setTransformOrigin(animatableValueToTransformOrigin(value, state));

return;