CSS Independent Transform Properties

Source/platform/transforms/TranslateTransformOperation.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 33 matching lines @@
     }
 
     virtual bool canBlendWith(const TransformOperation& other) const;
 
     double x(const FloatSize& borderBoxSize) const { return floatValueForLength(m_x, borderBoxSize.width()); }
     double y(const FloatSize& borderBoxSize) const { return floatValueForLength(m_y, borderBoxSize.height()); }
 
     Length x() const { return m_x; }
     Length y() const { return m_y; }
     double z() const { return m_z; }
-
-private:
     virtual OperationType type() const override { return m_type; }
 
     virtual bool operator==(const TransformOperation& o) const override

[Eric Willigers, 2015/06/11 02:15:19]

TranslateTransformOperation can be declared a final class. Same for other
operations.

[soonm, 2015/06/11 23:31:04]

Done.

     {
         if (!isSameType(o))
             return false;
         const TranslateTransformOperation* t = static_cast<const TranslateTransformOperation*>(&o);
         return m_x == t->m_x && m_y == t->m_y && m_z == t->m_z;
     }
 
+private:
     virtual void apply(TransformationMatrix& transform, const FloatSize& borderBoxSize) const override
     {
         transform.translate3d(x(borderBoxSize), y(borderBoxSize), z());
     }
 
     virtual PassRefPtr<TransformOperation> blend(const TransformOperation* from, double progress, bool blendToIdentity = false) override;
 
     virtual bool dependsOnBoxSize() const override
     {
         return m_x.hasPercent() || m_y.hasPercent();
     }
 
     TranslateTransformOperation(const Length& tx, const Length& ty, double tz, OperationType type)
         : m_x(tx)
         , m_y(ty)
         , m_z(tz)
         , m_type(type)
     {
         ASSERT(type == TranslateX || type == TranslateY || type == TranslateZ || type == Translate || type == Translate3D);
     }
 
     Length m_x;
     Length m_y;
     double m_z;
     OperationType m_type;
 };
 
+DEFINE_TRANSFORM_TYPE_CASTS(TranslateTransformOperation, isTranslateTransformOperation());
+
 } // namespace blink
 
 #endif // TranslateTransformOperation_h