CSS Independent Transform Properties

Source/core/css/parser/CSSPropertyParser.cpp

 /*
  * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
  * Copyright (C) 2012 Intel Corporation. All rights reserved.
  *
@@ skipping 1078 matching lines @@
         if (!list)
             return false;
         // These values are added to match gecko serialization.
         if (list->length() == 1)
             list->append(cssValuePool().createValue(50, CSSPrimitiveValue::CSS_PERCENTAGE));
         if (list->length() == 2)
             list->append(cssValuePool().createValue(0, CSSPrimitiveValue::CSS_PX));
         addProperty(propId, list.release(), important);
         return true;
     }
+
+    case CSSPropertyTranslate: {
+        // translate : [ <length> | <percentage> ] [[ <length> | <percentage> ] <length>? ]?
+        // defaults to 0 on all axis, note that the last value CANNOT be a percentage
+        ASSERT(RuntimeEnabledFeatures::cssIndependentTransformPropertiesEnabled());
+        RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
+        if (!validUnit(value, FLength) && !validUnit(value, FPercent)) {
+            return false;
+        }
+        list->append(createPrimitiveNumericValue(value));
+        value = m_valueList->next();
+
+        if (value) {
+            if (!validUnit(value, FLength) && !validUnit(value, FPercent))

[Timothy Loh, 2015/06/10 04:22:29]

validUnit(value, FLength | FPercent), also add tests with calc()

[soonm, 2015/06/11 23:31:03]

Done.

+                return false;
+            list->append(createPrimitiveNumericValue(value));
+            value = m_valueList->next();
+
+            if (value) {
+                if (!validUnit(value, FLength))
+                    return false;
+
+                list->append(createPrimitiveNumericValue(value));
+                value = m_valueList->next();
+            }
+        }
+
+        parsedValue = list.release();
+        break;
+    }
+
+    case CSSPropertyRotate: { // rotate : <angle> <number>{3}? defaults to a 0 0 1
+        ASSERT(RuntimeEnabledFeatures::cssIndependentTransformPropertiesEnabled());
+        RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
+        const unsigned maxAxis = 3;
+
+        if (!validUnit(value, FAngle))
+            return false;
+        list->append(createPrimitiveNumericValue(value));
+        value = m_valueList->next();
+
+        if (!value) {
+            parsedValue = list.release();
+            break;
+        }
+
+        for (unsigned i = 0; i < maxAxis; i++) {
+            if (!value || !validUnit(value, FNumber))
+                return false;
+            list->append(createPrimitiveNumericValue(value));
+            value = m_valueList->next();
+        }
+
+        parsedValue = list.release();
+        if (value)

[Timothy Loh, 2015/06/10 04:22:29]

don't need, checked outside the switch statement

[soonm, 2015/06/11 23:31:04]

Done - Removed

+            return false;
+        break;
+    }
+
+    case CSSPropertyScale: { // scale: <number>{1,3}, default scale for all axis is 1
+        ASSERT(RuntimeEnabledFeatures::cssIndependentTransformPropertiesEnabled());
+        RefPtrWillBeRawPtr<CSSValueList> scaleList = CSSValueList::createSpaceSeparated();
+        const unsigned maxAxis = 3;
+
+        for (unsigned i = 0; value && i < maxAxis; i++) {
+            if (!validUnit(value, FNumber))
+                return false;
+            scaleList->append(createPrimitiveNumericValue(value));
+            value = m_valueList->next();
+        }
+
+        if (value)

[Timothy Loh, 2015/06/10 04:22:29]

don't need, checked outside the switch statement

[soonm, 2015/06/11 23:31:04]

Done - Removed

+            return false;
+
+        parsedValue = scaleList.release();
+        break;
+    }
+
     case CSSPropertyWebkitPerspectiveOriginX:
     case CSSPropertyWebkitTransformOriginX:
         parsedValue = parseFillPositionX(m_valueList);
         if (parsedValue)
             m_valueList->next();
         break;
     case CSSPropertyWebkitPerspectiveOriginY:
     case CSSPropertyWebkitTransformOriginY:
         parsedValue = parseFillPositionY(m_valueList);
         if (parsedValue)
@@ skipping 7367 matching lines @@
         }
     }
 
     if (!list->length())
         return nullptr;
 
     return list.release();
 }
 
 } // namespace blink