Reduce how often LayoutSVGShape::updateShapeFromElement is called

Source/core/layout/svg/LayoutSVGShape.h

 /*
  * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
  * Copyright (C) 2005 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2006 Apple Computer, Inc
  * Copyright (C) 2009 Google, Inc.
  * Copyright (C) 2011 Renata Hodovan <reni@webkit.org>
  * Copyright (C) 2011 University of Szeged
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 32 matching lines @@
     PathGeometry,
     RectGeometryFastPath,
     EllipseGeometryFastPath
 };
 
 class LayoutSVGShape : public LayoutSVGModelObject {
 public:
     explicit LayoutSVGShape(SVGGeometryElement*);
     virtual ~LayoutSVGShape();
 
+    void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override final;
+
     void setNeedsShapeUpdate() { m_needsShapeUpdate = true; }
     virtual void setNeedsBoundariesUpdate() override final { m_needsBoundariesUpdate = true; }
     virtual void setNeedsTransformUpdate() override final { m_needsTransformUpdate = true; }
 
     bool nodeAtFloatPointInternal(const HitTestRequest&, const FloatPoint&, PointerEventsHitRules);
 
     Path& path() const
     {
         ASSERT(m_path);
         return *m_path;
     }
-    bool hasPath() const { return m_path.get(); }
 
     virtual bool isShapeEmpty() const { return path().isEmpty(); }
 
     bool hasNonScalingStroke() const { return style()->svgStyle().vectorEffect() == VE_NON_SCALING_STROKE; }
     Path* nonScalingStrokePath(const Path*, const AffineTransform&) const;
     AffineTransform nonScalingStrokeTransform() const;
     virtual AffineTransform localTransform() const override final { return m_localTransform ? *m_localTransform : LayoutSVGModelObject::localTransform(); }
 
     virtual const Vector<MarkerPosition>* markerPositions() const { return nullptr; }
 
     float strokeWidth() const;
 
     virtual ShapeGeometryCodePath geometryCodePath() const { return PathGeometry; }
     virtual const Vector<FloatPoint>* zeroLengthLineCaps() const { return nullptr; }
 
     virtual FloatRect objectBoundingBox() const override final { return m_fillBoundingBox; }
 
     virtual const char* name() const override { return "LayoutSVGShape"; }
 
 protected:
     void clearPath() { m_path.clear(); }
-    void createPath();
 
+    // Reconstruct the Path. Subclasses may use geometry knowledge to avoid creating a Path.
     virtual void updateShapeFromElement();
+
+    virtual void updateStrokeAndFillBoundingBoxes();
+
     // Calculates an inclusive bounding box of this shape as if this shape has
     // a stroke. If this shape has a stroke, then m_strokeBoundingBox is returned;
     // otherwise, estimates a bounding box (not necessarily tight) that would
     // include this shape's stroke bounding box if it had a stroke.
     virtual FloatRect hitTestStrokeBoundingBox() const;
     virtual bool shapeDependentStrokeContains(const FloatPoint&);
     virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) const;
 
     FloatRect m_fillBoundingBox;
     FloatRect m_strokeBoundingBox;
 
 private:
     // Hit-detection separated for the fill and the stroke
     bool fillContains(const FloatPoint&, bool requiresFill = true, const WindRule fillRule = RULE_NONZERO);
     bool strokeContains(const FloatPoint&, bool requiresStroke = true);
 
     virtual const AffineTransform& localToParentTransform() const override final { return m_localTransform ? *m_localTransform : LayoutSVGModelObject::localToParentTransform(); }
 
     virtual bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectSVGShape || LayoutSVGModelObject::isOfType(type); }
     virtual void layout() override final;
     virtual void paint(const PaintInfo&, const LayoutPoint&) override final;
     virtual void addFocusRingRects(Vector<LayoutRect>&, const LayoutPoint& additionalOffset) const override final;
 
     virtual bool nodeAtFloatPoint(HitTestResult&, const FloatPoint& pointInParent, HitTestAction) override final;
 
     virtual FloatRect strokeBoundingBox() const override final { return m_strokeBoundingBox; }
-    FloatRect calculateObjectBoundingBox() const;
-    FloatRect calculateStrokeBoundingBox() const;
+
     void updatePaintInvalidationBoundingBox();
     void updateLocalTransform();
 
 private:
     OwnPtr<AffineTransform> m_localTransform;
     OwnPtr<Path> m_path;
 
     bool m_needsBoundariesUpdate : 1;
     bool m_needsShapeUpdate : 1;
     bool m_needsTransformUpdate : 1;
 };
 
 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutSVGShape, isSVGShape());
 
 }
 
 #endif