Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: Source/core/layout/svg/LayoutSVGRect.h

Issue 1158583003: Reduce how often LayoutSVGShape::updateShapeFromElement is called (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix marker regression Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 University of Szeged 2 * Copyright (C) 2011 University of Szeged
3 * Copyright (C) 2011 Renata Hodovan <reni@webkit.org> 3 * Copyright (C) 2011 Renata Hodovan <reni@webkit.org>
4 * All rights reserved. 4 * All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 24 matching lines...) Expand all
35 class LayoutSVGRect final : public LayoutSVGShape { 35 class LayoutSVGRect final : public LayoutSVGShape {
36 public: 36 public:
37 explicit LayoutSVGRect(SVGRectElement*); 37 explicit LayoutSVGRect(SVGRectElement*);
38 virtual ~LayoutSVGRect(); 38 virtual ~LayoutSVGRect();
39 39
40 virtual ShapeGeometryCodePath geometryCodePath() const override { return m_u sePathFallback ? PathGeometry : RectGeometryFastPath; } 40 virtual ShapeGeometryCodePath geometryCodePath() const override { return m_u sePathFallback ? PathGeometry : RectGeometryFastPath; }
41 41
42 virtual const char* name() const override { return "LayoutSVGRect"; } 42 virtual const char* name() const override { return "LayoutSVGRect"; }
43 43
44 private: 44 private:
45 virtual void updateShapeFromElement() override; 45 void updateShapeFromElement() override final;
fs 2015/06/16 10:54:02 Nit: final
pdr. 2015/06/17 03:50:49 Done
46 void updateStrokeAndFillBoundingBoxes() override final;
46 virtual bool isShapeEmpty() const override { return m_usePathFallback ? Layo utSVGShape::isShapeEmpty() : m_fillBoundingBox.isEmpty(); } 47 virtual bool isShapeEmpty() const override { return m_usePathFallback ? Layo utSVGShape::isShapeEmpty() : m_fillBoundingBox.isEmpty(); }
47 virtual bool shapeDependentStrokeContains(const FloatPoint&) override; 48 virtual bool shapeDependentStrokeContains(const FloatPoint&) override;
48 virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) c onst override; 49 virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) c onst override;
49 bool definitelyHasSimpleStroke() const; 50 bool definitelyHasSimpleStroke() const;
50 51
51 private: 52 private:
52 bool m_usePathFallback; 53 bool m_usePathFallback;
53 }; 54 };
54 55
55 } 56 }
56 57
57 #endif 58 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698