Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 1158563008: [turbofan] Introduce prediction for exception handlers. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce prediction for exception handlers. This introduces a conservative prediction for each exception handler whether it will locally catch an exception or re-throw it to outside the code bondaries. It will allow for a more intuitive prediction of whether an exception is considered "caught" or "uncaught". R=bmeurer@chromium.org,yangguo@chromium.org BUG=chromium:492522 LOG=N Committed: https://crrev.com/d8b94f34cc2a4c1604ce8192765738f5ea56462f Cr-Commit-Position: refs/heads/master@{#28681}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Patch Set 3 : Architecture ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -30 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 3 chunks +11 lines, -3 lines 0 comments Download
M src/compiler/code-generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/compiler/common-operator.h View 1 2 chunks +9 lines, -1 line 0 comments Download
M src/compiler/common-operator.cc View 1 4 chunks +39 lines, -1 line 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/linkage.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/frames.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.h View 4 chunks +13 lines, -2 lines 0 comments Download
M src/objects.cc View 2 chunks +11 lines, -6 lines 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 1 5 chunks +22 lines, -5 lines 0 comments Download
M test/unittests/compiler/loop-peeling-unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/node-properties-unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M test/unittests/compiler/tail-call-optimization-unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Starzinger
Note that tests and ports are still missing. Benedikt: PTAL TurboFan internal parts. Yang: PTAL ...
5 years, 6 months ago (2015-05-28 11:20:33 UTC) #1
Yang
On 2015/05/28 11:20:33, Michael Starzinger wrote: > Note that tests and ports are still missing. ...
5 years, 6 months ago (2015-05-28 11:24:38 UTC) #2
Benedikt Meurer
LGTM once nit is addressed. https://codereview.chromium.org/1158563008/diff/1/src/compiler/common-operator.h File src/compiler/common-operator.h (right): https://codereview.chromium.org/1158563008/diff/1/src/compiler/common-operator.h#newcode97 src/compiler/common-operator.h:97: const Operator* IfException(bool caught_locally ...
5 years, 6 months ago (2015-05-28 11:28:18 UTC) #3
Michael Starzinger
https://codereview.chromium.org/1158563008/diff/1/src/compiler/common-operator.h File src/compiler/common-operator.h (right): https://codereview.chromium.org/1158563008/diff/1/src/compiler/common-operator.h#newcode97 src/compiler/common-operator.h:97: const Operator* IfException(bool caught_locally = false); On 2015/05/28 11:28:18, ...
5 years, 6 months ago (2015-05-28 12:33:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158563008/20002
5 years, 6 months ago (2015-05-28 13:21:02 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:20002)
5 years, 6 months ago (2015-05-28 13:22:55 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 13:23:12 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d8b94f34cc2a4c1604ce8192765738f5ea56462f
Cr-Commit-Position: refs/heads/master@{#28681}

Powered by Google App Engine
This is Rietveld 408576698