Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1158563003: [Effen] Make syncChild() support the _new_ child being null. (Closed)

Created:
5 years, 7 months ago by Hixie
Modified:
5 years, 7 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] Make syncChild() support the _new_ child being null. This is needed for cases where the UINode doesn't have a list of children (so it doesn't go through the RenderNodeWrapper sync logic that removes children), but it still has multiple slots, and needs to support removing nodes from those slots. (For example, removing a drawer from a ScaffoldContainer.) Also, expose syncChild (it used to be private) so it can be overridden in descendants outside fn.dart. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b3ae213fea49599055835eeb080b8ffad983ab61

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M sky/sdk/lib/framework/fn2.dart View 4 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 7 months ago (2015-05-27 18:00:16 UTC) #2
Hixie
5 years, 7 months ago (2015-05-27 18:00:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b3ae213fea49599055835eeb080b8ffad983ab61 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698