Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1158543004: X87: [es6] Support super.property in eval and arrow functions (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 6 months ago
Reviewers:
Weiliang
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] Support super.property in eval and arrow functions port 44e9810345cea9bfd6861905bc6856db7db5a25c (r28644) original commit message: When we enter a method that needs access to the [[HomeObject]] we allocate a local variable `.home_object` and assign it the value from the [[HomeObject]] private symbol. Something along the lines of: method() { var .home_object = %ThisFunction()[home_object_symbol]; ... } BUG= Committed: https://crrev.com/b471651e9677c9f2f834aa5a64db1861a0e785b6 Cr-Commit-Position: refs/heads/master@{#28717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -38 lines) Patch
M src/x87/full-codegen-x87.cc View 13 chunks +32 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 6 months ago (2015-06-01 06:15:14 UTC) #2
Weiliang
lgtm
5 years, 6 months ago (2015-06-01 08:22:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158543004/1
5 years, 6 months ago (2015-06-01 08:22:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 08:55:25 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 08:55:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b471651e9677c9f2f834aa5a64db1861a0e785b6
Cr-Commit-Position: refs/heads/master@{#28717}

Powered by Google App Engine
This is Rietveld 408576698