Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2949)

Unified Diff: chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_drag_controller.cc ('k') | chrome/test/base/in_process_browser_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
diff --git a/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc b/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
index bf165725464f874b4d84266af8a1772e77eac0dd..f75b93e2b86a1dc753b0320679289afa8624d85d 100644
--- a/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
+++ b/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
@@ -41,7 +41,7 @@ class TestBrowserWindowAura : public TestBrowserWindow {
~TestBrowserWindowAura() override {}
// TestBrowserWindow overrides:
- void Show() override {
+ void Show(bool user_gesture) override {
native_window_->Show();
Activate(user_gesture);
}
@@ -494,7 +494,7 @@ TEST_F(WindowSizerAshTest, MAYBE_PlaceNewWindows) {
gfx::Rect(32, 48, 256, 512),
Browser::CreateParams(Browser::TYPE_POPUP, profile.get(),
chrome::HOST_DESKTOP_TYPE_ASH)));
- browser_window->Show();
+ browser_window->Show(false /* user_gesture */);
{ // Make sure that popups do not get changed.
gfx::Rect window_bounds;
GetWindowBounds(p1600x1200, p1600x1200, gfx::Rect(),
@@ -638,7 +638,7 @@ TEST_F(WindowSizerAshTest, MAYBE_PlaceNewWindowsOnMultipleDisplays) {
CreateTestWindowInShellWithId(0),
gfx::Rect(10, 10, 200, 200),
Browser::CreateParams(profile.get(), chrome::HOST_DESKTOP_TYPE_ASH)));
- browser_window->Show();
+ browser_window->Show(false /* user_gesture */);
EXPECT_EQ(browser_window->GetNativeWindow()->GetRootWindow(),
ash::Shell::GetTargetRootWindow());
@@ -646,7 +646,7 @@ TEST_F(WindowSizerAshTest, MAYBE_PlaceNewWindowsOnMultipleDisplays) {
CreateTestWindowInShellWithId(1),
gfx::Rect(400, 10, 300, 300),
Browser::CreateParams(profile.get(), chrome::HOST_DESKTOP_TYPE_ASH)));
- another_browser_window->Show();
+ another_browser_window->Show(false /* user_gesture */);
// Creating a new window to verify the new placement.
scoped_ptr<TestBrowserWindowAura> new_browser_window(CreateTestBrowserWindow(
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_drag_controller.cc ('k') | chrome/test/base/in_process_browser_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698