Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1358)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 1687abfddb85ffb11e21ca53301c9da052280247..74086f2ff6f084983dafabc3a3a2dd200d203e3c 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -657,7 +657,7 @@ gfx::ImageSkia BrowserView::GetOTRAvatarIcon() const {
///////////////////////////////////////////////////////////////////////////////
// BrowserView, BrowserWindow implementation:
-void BrowserView::Show() {
+void BrowserView::Show(bool user_gesture) {
#if !defined(OS_WIN)
// The Browser associated with this browser window must become the active
// browser at the time |Show()| is called. This is the natural behavior under
@@ -672,6 +672,7 @@ void BrowserView::Show() {
// If the window is already visible, just activate it.
if (frame_->IsVisible()) {
+ // TODO(johnme): Pass user_gesture to Activate.
frame_->Activate();
return;
}
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.h ('k') | chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698