Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6969)

Unified Diff: chrome/browser/sessions/session_restore.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sessions/session_restore.cc
diff --git a/chrome/browser/sessions/session_restore.cc b/chrome/browser/sessions/session_restore.cc
index 396d7bc9089ea37ea39b1aafda4e11e2d0d2d576..39550fe7415d8c75da03df3578e26d56473f19eb 100644
--- a/chrome/browser/sessions/session_restore.cc
+++ b/chrome/browser/sessions/session_restore.cc
@@ -228,7 +228,8 @@ class SessionRestoreImpl : public content::NotificationObserver {
if (use_new_window) {
browser->tab_strip_model()->ActivateTabAt(0, true);
- browser->window()->Show();
+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+ browser->window()->Show(false /* user_gesture */);
}
NotifySessionServiceOfRestoredTabs(browser,
browser->tab_strip_model()->count());
@@ -293,7 +294,8 @@ class SessionRestoreImpl : public content::NotificationObserver {
urls_to_open_.push_back(GURL(chrome::kChromeUINewTabURL));
}
AppendURLsToBrowser(browser, urls_to_open_);
- browser->window()->Show();
+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+ browser->window()->Show(false /* user_gesture */);
}
if (succeeded) {
@@ -621,7 +623,8 @@ class SessionRestoreImpl : public content::NotificationObserver {
if (browser_ == browser)
return;
- browser->window()->Show();
+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+ browser->window()->Show(false /* user_gesture */);
browser->set_is_session_restore(false);
// TODO(jcampan): http://crbug.com/8123 we should not need to set the
« no previous file with comments | « chrome/browser/sessions/better_session_restore_browsertest.cc ('k') | chrome/browser/sessions/session_restore_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698