Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: chrome/browser/sessions/better_session_restore_browsertest.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/sdch_browsertest.cc ('k') | chrome/browser/sessions/session_restore.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/better_session_restore_browsertest.cc
diff --git a/chrome/browser/sessions/better_session_restore_browsertest.cc b/chrome/browser/sessions/better_session_restore_browsertest.cc
index b6c902602705912c394a4dfe3bd2a2f7ec7deb59..34e978d4a5579fa902faf563778797a738f47a55 100644
--- a/chrome/browser/sessions/better_session_restore_browsertest.cc
+++ b/chrome/browser/sessions/better_session_restore_browsertest.cc
@@ -481,7 +481,7 @@ IN_PROC_BROWSER_TEST_F(ContinueWhereILeftOffTest,
Browser::TYPE_POPUP,
browser()->profile(),
chrome::HOST_DESKTOP_TYPE_NATIVE));
- popup->window()->Show();
+ popup->window()->Show(false /* user_gesture */);
Browser* new_browser = QuitBrowserAndRestore(browser(), false);
// The browsing session will be continued; just wait for the page to reload
@@ -766,7 +766,7 @@ IN_PROC_BROWSER_TEST_F(NoSessionRestoreTest,
Browser::TYPE_POPUP,
browser()->profile(),
chrome::HOST_DESKTOP_TYPE_NATIVE));
- popup->window()->Show();
+ popup->window()->Show(false /* user_gesture */);
Browser* new_browser = QuitBrowserAndRestore(browser(), false);
NavigateAndCheckStoredData(new_browser, "session_cookies.html");
}
@@ -780,7 +780,7 @@ IN_PROC_BROWSER_TEST_F(NoSessionRestoreTest,
Browser::TYPE_POPUP,
browser()->profile(),
chrome::HOST_DESKTOP_TYPE_NATIVE));
- popup->window()->Show();
+ popup->window()->Show(false /* user_gesture */);
CloseBrowserSynchronously(browser(), false);
Browser* new_browser = QuitBrowserAndRestore(popup, false);
if (browser_defaults::kBrowserAliveWithNoWindows)
« no previous file with comments | « chrome/browser/net/sdch_browsertest.cc ('k') | chrome/browser/sessions/session_restore.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698