Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 1158523002: Add user_gesture param to BaseWindow::Show Base URL: https://chromium.googlesource.com/chromium/src.git@ug3_BaseWindow_Activate
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index be3d792c58170e0893cff605191894cd52f774fe..477e4c175dad6b11c6f6e6d80982397680d60a71 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -551,7 +551,7 @@ void DevToolsWindow::Show(const DevToolsToggleAction& action) {
inspected_window->UpdateDevTools();
main_web_contents_->SetInitialFocus();
- inspected_window->Show();
+ inspected_window->Show(true /* user_gesture */);
// On Aura, focusing once is not enough. Do it again.
// Note that focusing only here but not before isn't enough either. We just
// need to focus twice.
@@ -573,7 +573,7 @@ void DevToolsWindow::Show(const DevToolsToggleAction& action) {
CreateDevToolsBrowser();
if (should_show_window) {
- browser_->window()->Show();
+ browser_->window()->Show(true /* user_gesture */);
main_web_contents_->SetInitialFocus();
}
if (toolbox_web_contents_)
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698