Add user_gesture param to BaseWindow::Show

chrome/browser/ui/browser_commands.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_commands.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 175 matching lines @@
               TabStripModel::ADD_ACTIVE : TabStripModel::ADD_NONE);
       return new_tab;
     }
     case NEW_WINDOW: {
       WebContents* new_tab = current_tab->Clone();
       Browser* new_browser = new Browser(Browser::CreateParams(
           browser->profile(), browser->host_desktop_type()));
       new_browser->tab_strip_model()->AddWebContents(
           new_tab, -1, ui::PAGE_TRANSITION_LINK,
           TabStripModel::ADD_ACTIVE);
-      new_browser->window()->Show();
+      new_browser->window()->Show(true /* user_gesture */);
       return new_tab;
     }
     default:
       browser->window()->GetLocationBar()->Revert();
       return current_tab;
   }
 }
 
 void ReloadInternal(Browser* browser,
                     WindowOpenDisposition disposition,
@@ skipping 132 matching lines @@
         !session_service->RestoreIfNecessary(std::vector<GURL>())) {
       OpenEmptyWindow(profile->GetOriginalProfile(), desktop_type);
     }
   }
 }
 
 Browser* OpenEmptyWindow(Profile* profile, HostDesktopType desktop_type) {
   Browser* browser = new Browser(
       Browser::CreateParams(Browser::TYPE_TABBED, profile, desktop_type));
   AddTabAt(browser, GURL(), -1, true);
-  browser->window()->Show();
+  browser->window()->Show(true /* user_gesture */);
   return browser;
 }
 
 void OpenWindowWithRestoredTabs(Profile* profile,
                                 HostDesktopType host_desktop_type) {
   TabRestoreService* service = TabRestoreServiceFactory::GetForProfile(profile);
   if (service)
     service->RestoreMostRecentEntry(NULL, host_desktop_type);
 }
 
@@ skipping 185 matching lines @@
                             TabStripModel::NEW_TAB_ENUM_COUNT);
 
   if (browser->is_type_tabbed()) {
     AddTabAt(browser, GURL(), -1, true);
     browser->tab_strip_model()->GetActiveWebContents()->RestoreFocus();
   } else {
     ScopedTabbedBrowserDisplayer displayer(browser->profile(),
                                            browser->host_desktop_type());
     Browser* b = displayer.browser();
     AddTabAt(b, GURL(), -1, true);
-    b->window()->Show();
+    // TODO(johnme): Pass true to |Show| for user-initiated commands.
+    b->window()->Show(false /* user_gesture */);
     // The call to AddBlankTabAt above did not set the focus to the tab as its
     // window was not active, so we have to do it explicitly.
     // See http://crbug.com/6380.
     b->tab_strip_model()->GetActiveWebContents()->RestoreFocus();
   }
 }
 
 void CloseTab(Browser* browser) {
   content::RecordAction(UserMetricsAction("CloseTab_Accelerator"));
   browser->tab_strip_model()->CloseSelectedTabs();
@@ skipping 103 matching lines @@
                                 browser->host_desktop_type()));
     }
     // Preserve the size of the original window. The new window has already
     // been given an offset by the OS, so we shouldn't copy the old bounds.
     BrowserWindow* new_window = new_browser->window();
     new_window->SetBounds(gfx::Rect(new_window->GetRestoredBounds().origin(),
                           browser->window()->GetRestoredBounds().size()));
 
     // We need to show the browser now.  Otherwise ContainerWin assumes the
     // WebContents is invisible and won't size it.
-    new_browser->window()->Show();
+    // TODO(johnme): Pass true to |Show| for user-initiated commands.
+    new_browser->window()->Show(false /* user_gesture */);
 
     // The page transition below is only for the purpose of inserting the tab.
     new_browser->tab_strip_model()->AddWebContents(
         contents_dupe, -1,
         ui::PAGE_TRANSITION_LINK,
         TabStripModel::ADD_ACTIVE);
   }
 
   SessionService* session_service =
       SessionServiceFactory::GetForProfileIfExisting(browser->profile());
   if (session_service)
     session_service->TabRestored(contents_dupe, pinned);
   return contents_dupe;
 }
 
 bool CanDuplicateTabAt(Browser* browser, int index) {
   content::NavigationController& nc =
       browser->tab_strip_model()->GetWebContentsAt(index)->GetController();
   return nc.GetWebContents() && nc.GetLastCommittedEntry();
 }
 
 void ConvertPopupToTabbedBrowser(Browser* browser) {
   content::RecordAction(UserMetricsAction("ShowAsTab"));
   TabStripModel* tab_strip = browser->tab_strip_model();
   WebContents* contents =
       tab_strip->DetachWebContentsAt(tab_strip->active_index());
   Browser* b = new Browser(Browser::CreateParams(browser->profile(),
                                                  browser->host_desktop_type()));
   b->tab_strip_model()->AppendWebContents(contents, true);
-  b->window()->Show();
+  b->window()->Show(true /* user_gesture */);
 }
 
 void Exit() {
   content::RecordAction(UserMetricsAction("Exit"));
   chrome::AttemptUserExit();
 }
 
 void BookmarkCurrentPageIgnoringExtensionOverrides(Browser* browser) {
   content::RecordAction(UserMetricsAction("Star"));
 
@@ skipping 480 matching lines @@
                               browser->host_desktop_type()));
 
     // Preserve the size of the original window. The new window has already
     // been given an offset by the OS, so we shouldn't copy the old bounds.
     BrowserWindow* new_window = b->window();
     new_window->SetBounds(gfx::Rect(new_window->GetRestoredBounds().origin(),
                           browser->window()->GetRestoredBounds().size()));
 
     // We need to show the browser now. Otherwise ContainerWin assumes the
     // WebContents is invisible and won't size it.
-    b->window()->Show();
+    b->window()->Show(true /* user_gesture */);
 
     // The page transition below is only for the purpose of inserting the tab.
     b->tab_strip_model()->AddWebContents(view_source_contents, -1,
                                          ui::PAGE_TRANSITION_LINK,
                                          TabStripModel::ADD_ACTIVE);
   }
 
   SessionService* session_service =
       SessionServiceFactory::GetForProfileIfExisting(browser->profile());
   if (session_service)
@@ skipping 49 matching lines @@
   Browser* app_browser = new Browser(
       Browser::CreateParams::CreateForApp(app_name,
                                           true /* trusted_source */,
                                           gfx::Rect(),
                                           browser->profile(),
                                           browser->host_desktop_type()));
   app_browser->tab_strip_model()->AppendWebContents(contents, true);
 
   contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
   contents->GetRenderViewHost()->SyncRendererPrefs();
-  app_browser->window()->Show();
+  app_browser->window()->Show(true /* user_gesture */);
 }
 #endif  // defined(ENABLE_EXTENSIONS)
 
 }  // namespace chrome