Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1158483004: Merge to XFA: Automated test case for 487928. (Closed)

Created:
5 years, 6 months ago by Tom Sepez
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Tidy after merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -59 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdfformfill_embeddertest.cpp View 3 chunks +15 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M testing/embedder_test.h View 3 chunks +10 lines, -1 line 0 comments Download
M testing/embedder_test.cpp View 1 7 chunks +28 lines, -58 lines 0 comments Download
M testing/embedder_test_mock_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
A testing/embedder_test_timer_handling_delegate.h View 1 chunk +54 lines, -0 lines 0 comments Download
A testing/resources/bug_487928.in View 1 chunk +122 lines, -0 lines 0 comments Download
A testing/resources/bug_487928.pdf View 1 1 chunk +180 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR.
5 years, 6 months ago (2015-06-03 00:06:36 UTC) #1
Lei Zhang
lgtm
5 years, 6 months ago (2015-06-03 00:10:49 UTC) #2
Tom Sepez
5 years, 6 months ago (2015-06-03 00:11:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6efc0ad16665ab74c5033bdc36dbcb7c8aad7e6c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698