Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1412)

Unified Diff: Source/modules/compositorworker/CompositorWorkerThread.h

Issue 1158443008: compositor-worker: Share a thread and an isolate for compositor workers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: . Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/compositorworker/CompositorWorkerThread.h
diff --git a/Source/modules/compositorworker/CompositorWorkerThread.h b/Source/modules/compositorworker/CompositorWorkerThread.h
index 7c62b3b23fd2a1545b0c9e80fecffa164875f24f..8f4752c8eac8941115f0a5076043e81226b00efa 100644
--- a/Source/modules/compositorworker/CompositorWorkerThread.h
+++ b/Source/modules/compositorworker/CompositorWorkerThread.h
@@ -11,23 +11,31 @@ namespace blink {
class WorkerObjectProxy;
-class CompositorWorkerThread final : public WorkerThread {
+// This class is overridden in unit-tests.
+class CompositorWorkerThread : public WorkerThread {
public:
static PassRefPtr<CompositorWorkerThread> create(PassRefPtr<WorkerLoaderProxy>, WorkerObjectProxy&, double timeOrigin);
virtual ~CompositorWorkerThread();
WorkerObjectProxy& workerObjectProxy() const { return m_workerObjectProxy; }
-private:
+protected:
CompositorWorkerThread(PassRefPtr<WorkerLoaderProxy>, WorkerObjectProxy&, double timeOrigin);
+private:
// WorkerThread:
PassRefPtrWillBeRawPtr<WorkerGlobalScope> createWorkerGlobalScope(PassOwnPtr<WorkerThreadStartupData>) override;
WebThreadSupportingGC& backingThread() override;
+ PassOwnPtr<WorkerIsolateWrapper> createIsolateWrapper() override;
+ void didStartRunLoop() override { }
+ void didStopRunLoop() override { }
+ void initializeBackingThread() override;
+ void shutdownBackingThread() override;
+
+ WebThreadSupportingGC* m_thread = nullptr;
haraken 2015/06/02 02:14:49 It looks nasty to keep a raw pointer to the WebThr
sadrul 2015/06/02 02:48:28 Done.
WorkerObjectProxy& m_workerObjectProxy;
double m_timeOrigin;
- OwnPtr<WebThreadSupportingGC> m_thread;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698