Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1158443004: [turbofan] Fix known issue about computed property names. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix known issue about computed property names. This fixes a corner-case where deoptimization while evaluating the value to a __proto__ property after computed property names appeared in an object literal, lead to environments not being in sync with unoptimized code. R=arv@chromium.org TEST=mjsunit/harmony/computed-property-names-deopt Committed: https://crrev.com/ce551f91fd18069bc6786c6c71d111fb1ebca683 Cr-Commit-Position: refs/heads/master@{#28613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -9 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +14 lines, -9 lines 0 comments Download
A test/mjsunit/harmony/computed-property-names-deopt.js View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 7 months ago (2015-05-22 14:10:52 UTC) #1
arv (Not doing code reviews)
lgtm
5 years, 7 months ago (2015-05-22 15:10:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158443004/1
5 years, 7 months ago (2015-05-26 08:19:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-26 08:45:15 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 08:45:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce551f91fd18069bc6786c6c71d111fb1ebca683
Cr-Commit-Position: refs/heads/master@{#28613}

Powered by Google App Engine
This is Rietveld 408576698